Re: kobject link failure

2007-07-20 Thread Jan Engelhardt
On Jul 20 2007 08:06, Greg KH wrote: >> Leaving kobject_actions[] in kobject_uevent.c, but putting it outside >> the #ifdef looks indeed like the best solution to me. This way, we >> avoid adding #ifdef CONFIG_HOTPLUG into core.c, when all other >> functions called do not need such a thing. > >Yea

Re: kobject link failure

2007-07-20 Thread Greg KH
On Fri, Jul 20, 2007 at 01:58:13PM +0200, Cornelia Huck wrote: > On Fri, 20 Jul 2007 11:32:21 +0200, > Cornelia Huck <[EMAIL PROTECTED]> wrote: > > > Hm, this would be an interface change (the uevent attribute used to > > exist even for !CONFIG_HOTPLUG, it just triggered nothing). How about > > mo

Re: kobject link failure

2007-07-20 Thread Cornelia Huck
On Fri, 20 Jul 2007 11:32:21 +0200, Cornelia Huck <[EMAIL PROTECTED]> wrote: > Hm, this would be an interface change (the uevent attribute used to > exist even for !CONFIG_HOTPLUG, it just triggered nothing). How about > moving kobject_actions[] out of the #ifdef (maybe next to > kobject_action)?

Re: kobject link failure

2007-07-20 Thread Cornelia Huck
On Fri, 20 Jul 2007 01:00:59 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -250,6 +250,7 @@ static struct kset_uevent_ops device_uev > .uevent = dev_uevent, > }; > > +#ifdef CONFIG_HOTPLUG > static ssize_t show_uevent(struct

Re: kobject link failure

2007-07-20 Thread Greg KH
On Thu, Jul 19, 2007 at 08:11:26PM +0200, Gabriel C wrote: > Jan Engelhardt wrote: > > Hi, > > > > > > top is 275afcac9953ece0828972edeab9684cfe1a5ef3, error is: > > LD .tmp_vmlinux1 > > drivers/built-in.o: In function `store_uevent': > > core.c:(.text+0x20ebb): undefined reference to `kobje

Re: kobject link failure

2007-07-19 Thread Jan Engelhardt
On Jul 19 2007 12:18, Greg KH wrote: >On Thu, Jul 19, 2007 at 08:03:06PM +0200, Jan Engelhardt wrote: >> >> top is 275afcac9953ece0828972edeab9684cfe1a5ef3, error is: >> LD .tmp_vmlinux1 >> drivers/built-in.o: In function `store_uevent': >> core.c:(.text+0x20ebb): undefined reference to `k

Re: kobject link failure

2007-07-19 Thread Greg KH
On Thu, Jul 19, 2007 at 08:03:06PM +0200, Jan Engelhardt wrote: > Hi, > > > top is 275afcac9953ece0828972edeab9684cfe1a5ef3, error is: > LD .tmp_vmlinux1 > drivers/built-in.o: In function `store_uevent': > core.c:(.text+0x20ebb): undefined reference to `kobject_actions' > core.c:(.text+0x2

Re: kobject link failure

2007-07-19 Thread Greg KH
On Thu, Jul 19, 2007 at 08:11:26PM +0200, Gabriel C wrote: > Jan Engelhardt wrote: > > Hi, > > > > > > top is 275afcac9953ece0828972edeab9684cfe1a5ef3, error is: > > LD .tmp_vmlinux1 > > drivers/built-in.o: In function `store_uevent': > > core.c:(.text+0x20ebb): undefined reference to `kobje

Re: kobject link failure

2007-07-19 Thread Gabriel C
Jan Engelhardt wrote: > Hi, > > > top is 275afcac9953ece0828972edeab9684cfe1a5ef3, error is: > LD .tmp_vmlinux1 > drivers/built-in.o: In function `store_uevent': > core.c:(.text+0x20ebb): undefined reference to `kobject_actions' > core.c:(.text+0x20edd): undefined reference to `kobject_actio