Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Andrew Vasquez
On Tue, 29 Jan 2008, Luck, Tony wrote: > > > Will try this next. > > > > Should work even better since it avoids a lock and copy, but please do > > test if you have the time. > > That one works too (survived two full builds at "make -j32" on the 16-way > system). > > Thanks for the quick turnaro

RE: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Luck, Tony
> > Will try this next. > > Should work even better since it avoids a lock and copy, but please do > test if you have the time. That one works too (survived two full builds at "make -j32" on the 16-way system). Thanks for the quick turnaround. -Tony -- To unsubscribe from this list: send the lin

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Jens Axboe
On Tue, Jan 29 2008, Luck, Tony wrote: > >> Ah crap, I see the problem, nioc is most often equal to rioc. Dang. > >> Please try this bandaid, will push a real fix now. > > Patches arriving faster than I can test :-) ... The bandaid appears to > be working (no hang yet). OK good! > > This is way

RE: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Luck, Tony
>> Ah crap, I see the problem, nioc is most often equal to rioc. Dang. >> Please try this bandaid, will push a real fix now. Patches arriving faster than I can test :-) ... The bandaid appears to be working (no hang yet). > This is way cleaner. Will try this next. -Tony -- To unsubscribe from t

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Jens Axboe
On Tue, Jan 29 2008, Jens Axboe wrote: > On Tue, Jan 29 2008, Andrew Vasquez wrote: > > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > > > Great, thanks for confirming. It does look like a clear bug in cciss, it > > > just got exposed now that it uses proper end request handling. We never > > > need

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Jens Axboe
On Tue, Jan 29 2008, Andrew Vasquez wrote: > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > Great, thanks for confirming. It does look like a clear bug in cciss, it > > just got exposed now that it uses proper end request handling. We never > > need to clear ->data_len, since for blk_fs_request() it

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Andrew Vasquez
On Tue, 29 Jan 2008, Jens Axboe wrote: > Great, thanks for confirming. It does look like a clear bug in cciss, it > just got exposed now that it uses proper end request handling. We never > need to clear ->data_len, since for blk_fs_request() it will be cleared > on init. So just setting a residua

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Andrew Vasquez
Mike (OS Dev); > > [EMAIL PROTECTED]; [EMAIL PROTECTED] > > Subject: Re: kernel BUG at drivers/block/cciss.c:1260! (with > > recent linux-2.6 tree) > > > > On Tue, Jan 29 2008, Andrew Vasquez wrote: > > > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > &g

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Jens Axboe
Mike (OS Dev); > > [EMAIL PROTECTED]; [EMAIL PROTECTED] > > Subject: Re: kernel BUG at drivers/block/cciss.c:1260! (with > > recent linux-2.6 tree) > > > > On Tue, Jan 29 2008, Andrew Vasquez wrote: > > > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > > >

RE: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Miller, Mike (OS Dev)
Jens wrote: > -Original Message- > From: Jens Axboe [mailto:[EMAIL PROTECTED] > Sent: Tuesday, January 29, 2008 12:54 PM > To: Andrew Vasquez > Cc: Linux Kernel Mailing List; Miller, Mike (OS Dev); > [EMAIL PROTECTED]; [EMAIL PROTECTED] > Subject: Re: kernel BUG at

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Jens Axboe
On Tue, Jan 29 2008, Andrew Vasquez wrote: > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > On Tue, Jan 29 2008, Andrew Vasquez wrote: > > > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > > > > > > Here the final snippet that was logged: > > > > > > > > > > [ 12.724997] input: USB HID v1.01 Mouse

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Andrew Vasquez
On Tue, 29 Jan 2008, Jens Axboe wrote: > On Tue, Jan 29 2008, Andrew Vasquez wrote: > > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > > > > Here the final snippet that was logged: > > > > > > > > [ 12.724997] input: USB HID v1.01 Mouse [HP Virtual Keyboard] on > > > > usb-:01:04.4-1 > > >

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Jens Axboe
On Tue, Jan 29 2008, Andrew Vasquez wrote: > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > > Here the final snippet that was logged: > > > > > > [ 12.724997] input: USB HID v1.01 Mouse [HP Virtual Keyboard] on > > > usb-:01:04.4-1 > > > [ 12.728971] usbcore: registered new interface drive

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Andrew Vasquez
On Tue, 29 Jan 2008, Jens Axboe wrote: > > Here the final snippet that was logged: > > > > [ 12.724997] input: USB HID v1.01 Mouse [HP Virtual Keyboard] on > > usb-:01:04.4-1 > > [ 12.728971] usbcore: registered new interface driver usbhid > > [ 12.732866] drivers/hid/usbhid/hid-core.c

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Jens Axboe
On Tue, Jan 29 2008, Andrew Vasquez wrote: > On Tue, 29 Jan 2008, Jens Axboe wrote: > > > Andrew, can you try with this applied? > > > > diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c > > index ef50068..bd7b352 100644 > > --- a/drivers/block/cciss.c > > +++ b/drivers/block/cciss.c > >

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Andrew Vasquez
On Tue, 29 Jan 2008, Jens Axboe wrote: > Andrew, can you try with this applied? > > diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c > index ef50068..bd7b352 100644 > --- a/drivers/block/cciss.c > +++ b/drivers/block/cciss.c > @@ -1257,7 +1257,7 @@ static void cciss_softirq_done(struct

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Jens Axboe
On Tue, Jan 29 2008, Jens Axboe wrote: > On Tue, Jan 29 2008, Andrew Vasquez wrote: > > Hitting a consistent BUG() with recent Linus' linux-2.6.git: > > > > [ 12.941428] [ cut here ] > > [ 12.944874] kernel BUG at drivers/block/cciss.c:1260! > > [ 12.94487

Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

2008-01-29 Thread Jens Axboe
On Tue, Jan 29 2008, Andrew Vasquez wrote: > Hitting a consistent BUG() with recent Linus' linux-2.6.git: > > [ 12.941428] [ cut here ] > [ 12.944874] kernel BUG at drivers/block/cciss.c:1260! > [ 12.944874] invalid opcode: [1] SMP > [