Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-12 Thread Ian Armstrong
On Sun, 11 Mar 2018 23:04:02 -0500 Nick French wrote: > On Sun, Mar 11, 2018 at 11:24:38PM +, Ian Armstrong wrote: > > On Sat, 10 Mar 2018 16:57:41 + > > "French, Nicholas A." wrote: > > > > > > > No what if the framebuffer driver is just requested as a > > > > > secondary step after

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-11 Thread Nick French
On Sun, Mar 11, 2018 at 11:24:38PM +, Ian Armstrong wrote: > On Sat, 10 Mar 2018 16:57:41 + > "French, Nicholas A." wrote: > > > > > No what if the framebuffer driver is just requested as a > > > > secondary step after firmware loading? > > > > > > Its a possibility. The decoder firmwar

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-11 Thread Ian Armstrong
On Sat, 10 Mar 2018 16:57:41 + "French, Nicholas A." wrote: > > > No what if the framebuffer driver is just requested as a > > > secondary step after firmware loading? > > > > Its a possibility. The decoder firmware gets loaded at the > > beginning of the decoder memory range and we know it

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-11 Thread Nick French
On Sun, Mar 11, 2018 at 01:19:03PM -0700, Andy Lutomirski wrote: > From memory, I see two potentially reasonable real fixes. One is to find a > way to punch a hole in an ioremap. > So you’d find the framebuffer, remove it from theproblematic mapping, and > then make a new mapping. > The second i

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-11 Thread Andy Lutomirski
> On Mar 11, 2018, at 12:51 PM, Nick French wrote: > > On Sat, Mar 10, 2018 at 10:20:23AM -0800, Andy Lutomirski wrote: Perhaps the easy answer is to change the fatal is-pat-enabled check to just a warning like "you have PAT enabled, so wc is disabled for the framebuffer.

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-11 Thread Nick French
On Sat, Mar 10, 2018 at 10:20:23AM -0800, Andy Lutomirski wrote: >>> Perhaps the easy answer is to change the fatal is-pat-enabled check to just >>> a warning like "you have PAT enabled, so wc is disabled for the framebuffer. >>> if you want wc, use the nopat parameter"? >> >> I like this idea more

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-10 Thread Luis R. Rodriguez
On Sat, Mar 10, 2018 at 11:03 AM, Luis R. Rodriguez wrote: > On Sat, Mar 10, 2018 at 8:57 AM, French, Nicholas A. wrote: >> On Wed, Mar 07, 2018 at 11:23:09PM -0600, French, Nicholas A. wrote: >>> On Thu, Mar 08, 2018 at 04:14:11AM +, Luis R. Rodriguez wrote: >>> > On Thu, Mar 08, 2018 at 04:

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-10 Thread Luis R. Rodriguez
On Sat, Mar 10, 2018 at 8:57 AM, French, Nicholas A. wrote: > On Wed, Mar 07, 2018 at 11:23:09PM -0600, French, Nicholas A. wrote: >> On Thu, Mar 08, 2018 at 04:14:11AM +, Luis R. Rodriguez wrote: >> > On Thu, Mar 08, 2018 at 04:06:01AM +, Luis R. Rodriguez wrote: >> > > On Thu, Mar 08, 20

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-10 Thread Andy Lutomirski
> On Mar 10, 2018, at 8:57 AM, French, Nicholas A. wrote: > >> On Wed, Mar 07, 2018 at 11:23:09PM -0600, French, Nicholas A. wrote: >>> On Thu, Mar 08, 2018 at 04:14:11AM +, Luis R. Rodriguez wrote: On Thu, Mar 08, 2018 at 04:06:01AM +, Luis R. Rodriguez wrote: > On Thu, Mar 0

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-10 Thread French, Nicholas A.
On Wed, Mar 07, 2018 at 11:23:09PM -0600, French, Nicholas A. wrote: > On Thu, Mar 08, 2018 at 04:14:11AM +, Luis R. Rodriguez wrote: > > On Thu, Mar 08, 2018 at 04:06:01AM +, Luis R. Rodriguez wrote: > > > On Thu, Mar 08, 2018 at 03:16:29AM +, French, Nicholas A. wrote: > > > > > > > >

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-07 Thread French, Nicholas A.
On Thu, Mar 08, 2018 at 04:14:11AM +, Luis R. Rodriguez wrote: > On Thu, Mar 08, 2018 at 04:06:01AM +, Luis R. Rodriguez wrote: > > On Thu, Mar 08, 2018 at 03:16:29AM +, French, Nicholas A. wrote: > > > > > > Ah, I see. So my proposed ioremap_wc call was only "working" by aliasing >

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-07 Thread Luis R. Rodriguez
On Thu, Mar 08, 2018 at 04:06:01AM +, Luis R. Rodriguez wrote: > On Thu, Mar 08, 2018 at 03:16:29AM +, French, Nicholas A. wrote: > > On Wed, Mar 07, 2018 at 07:02:05PM +, Luis R. Rodriguez wrote: > > > On Tue, Mar 06, 2018 at 09:01:10PM +, French, Nicholas A. wrote: > > > > any rea

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-07 Thread Luis R. Rodriguez
On Thu, Mar 08, 2018 at 03:16:29AM +, French, Nicholas A. wrote: > On Wed, Mar 07, 2018 at 07:02:05PM +, Luis R. Rodriguez wrote: > > On Tue, Mar 06, 2018 at 09:01:10PM +, French, Nicholas A. wrote: > > > any reason why PAT can't be enabled for ivtvfb as simply as in the > > > attached

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-07 Thread French, Nicholas A.
On Wed, Mar 07, 2018 at 07:02:05PM +, Luis R. Rodriguez wrote: > On Tue, Mar 06, 2018 at 09:01:10PM +, French, Nicholas A. wrote: > > any reason why PAT can't be enabled for ivtvfb as simply as in the attached > > patch? > > Prior to your change the OSD buffer was obtained using the itv->de

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-07 Thread Luis R. Rodriguez
On Tue, Mar 06, 2018 at 09:01:10PM +, French, Nicholas A. wrote: > any reason why PAT can't be enabled for ivtvfb as simply as in the attached > patch? diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c index 621b2f613d81..69de110726e8 100644 --- a/drivers/media/pci