Re: is L1 really disabled in iwlwifi

2013-05-16 Thread Emmanuel Grumbach
> > I couldn't imagine that silently ignoring the request to disable ASPM > would be the right thing, but I spent a long time experimenting with > Windows on qemu, and I think you're right. Windows 7 also seems to > ignore the "PciASPMOptOut" directive when we don't have permission > to manage ASP

Re: is L1 really disabled in iwlwifi

2013-05-16 Thread Bjorn Helgaas
On Sat, May 11, 2013 at 08:22:11PM +, Matthew Garrett wrote: > On Sat, 2013-05-11 at 22:26 +0200, Rafael J. Wysocki wrote: > > On Friday, May 10, 2013 04:52:57 PM Bjorn Helgaas wrote: > > > I propose the following patch. Any comments? > > > > In my opinion this is dangerous, because it opens

Re: is L1 really disabled in iwlwifi

2013-05-11 Thread Matthew Garrett
On Sat, 2013-05-11 at 22:26 +0200, Rafael J. Wysocki wrote: > On Friday, May 10, 2013 04:52:57 PM Bjorn Helgaas wrote: > > I propose the following patch. Any comments? > > In my opinion this is dangerous, because it opens us to bugs that right now > are prevented from happening due to the way the

Re: is L1 really disabled in iwlwifi

2013-05-11 Thread Rafael J. Wysocki
On Friday, May 10, 2013 04:52:57 PM Bjorn Helgaas wrote: > [+cc Rafael, other pci_disable_link_state() users] > > On Wed, May 01, 2013 at 11:13:15AM -0600, Bjorn Helgaas wrote: > > On Wed, May 1, 2013 at 2:31 AM, Emmanuel Grumbach > > wrote: > > > [from Bjorn's mail] > > >> In Emmanuel's case, w

Re: is L1 really disabled in iwlwifi

2013-05-10 Thread Bjorn Helgaas
[+cc Rafael, other pci_disable_link_state() users] On Wed, May 01, 2013 at 11:13:15AM -0600, Bjorn Helgaas wrote: > On Wed, May 1, 2013 at 2:31 AM, Emmanuel Grumbach wrote: > > [from Bjorn's mail] > >> In Emmanuel's case, we don't get _OSC control, so > >> pci_disable_link_state() does nothing. >