Re: iommu: Improve exception handling in iommu_group_alloc()

2020-06-02 Thread Markus Elfring
>> Do you disagree to the application of the Linux coding style then >> for the recommended exception handling? > > No, that's not what I mean. My point is the exception handling in this > patch is simple and no need to add 'goto' statement which does not help > to improve readability. Do we come

Re: iommu: Improve exception handling in iommu_group_alloc()

2020-06-01 Thread Baolin Wang
On Tue, Jun 02, 2020 at 07:01:02AM +0200, Markus Elfring wrote: > >> * I suggest to avoid the specification of duplicate function calls. > >> Will it be helpful to add a few jump targets? > >> > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/co

Re: iommu: Improve exception handling in iommu_group_alloc()

2020-06-01 Thread Markus Elfring
>> * I suggest to avoid the specification of duplicate function calls. >> Will it be helpful to add a few jump targets? >> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162#n455 > > I do