Re: iio/accel/stk8312: Improve unlocking of a mutex in two functions

2017-10-27 Thread SF Markus Elfring
>> But I proposed an other source code layout for useful reasons. > > I think there is a (hidden) cost of having pure cleanup patches: > they make backporting fixes harder (across the cleanup) There the usual software development consequences to consider if you dare to change the source code at a

Re: iio/accel/stk8312: Improve unlocking of a mutex in two functions

2017-10-27 Thread Peter Meerwald-Stadler
Hello, > Maybe … > But I proposed an other source code layout for useful reasons. I think there is a (hidden) cost of having pure cleanup patches: they make backporting fixes harder (across the cleanup) stylistic changes must have a clear benefit, readability is subjective, consistency per se d

Re: iio/accel/stk8312: Improve unlocking of a mutex in two functions

2017-10-27 Thread SF Markus Elfring
> In the second case, the jump backwards just makes the code harder > to read than it currently is. Maybe … But I proposed an other source code layout for useful reasons. > There is no firm rule about error handling in one place. There are some design options available. > If it leads to more