Re: i8k: move driver from char to hwmon

2015-04-22 Thread Pali Rohár
On Wednesday 22 April 2015 10:23:04 Jean Delvare wrote: > On Sun, 22 Feb 2015 10:11:16 -0800, Guenter Roeck wrote: > > On 02/22/2015 09:44 AM, Pali Rohár wrote: > > > What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for > > > mandatory core & hwmon code and (keep existing) CONFIG_I8K for

Re: i8k: move driver from char to hwmon

2015-04-22 Thread Jean Delvare
On Sun, 22 Feb 2015 10:11:16 -0800, Guenter Roeck wrote: > On 02/22/2015 09:44 AM, Pali Rohár wrote: > > What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for > > mandatory core & hwmon code and (keep existing) CONFIG_I8K for > > /proc/i8k? > > One option might be to leave CONFIG_I8K mor

Re: i8k: move driver from char to hwmon

2015-02-22 Thread Guenter Roeck
On 02/22/2015 02:07 PM, Jean Delvare wrote: On Sun, 22 Feb 2015 10:11:16 -0800, Guenter Roeck wrote: I would still leave the driver name alone, though; the problem is that "modprobe i8k" is mentioned in pretty much all references to the driver. This might be solved with a module alias? You can

Re: i8k: move driver from char to hwmon

2015-02-22 Thread Jean Delvare
On Sun, 22 Feb 2015 10:11:16 -0800, Guenter Roeck wrote: > I would still leave the driver name alone, though; the problem > is that "modprobe i8k" is mentioned in pretty much all references > to the driver. This might be solved with a module alias? You can pass any arbitrary string to MODULE_ALIAS

Re: i8k: move driver from char to hwmon

2015-02-22 Thread Guenter Roeck
On 02/22/2015 09:44 AM, Pali Rohár wrote: On Sunday 22 February 2015 18:33:16 Guenter Roeck wrote: 2) Rename driver from i8k to something like delldiag or dellsmm Might be problematic, as it would break existing configurations unless you keep the CONFIG_I8K but rename the driver. Driver name

Re: i8k: move driver from char to hwmon

2015-02-22 Thread Guenter Roeck
On 02/22/2015 09:44 AM, Pali Rohár wrote: On Sunday 22 February 2015 18:33:16 Guenter Roeck wrote: On 02/22/2015 03:50 AM, Pali Rohár wrote: Hello, currently i8k driver for DELLDIAG SMM operations (charger, battery, hotkeys, temperature and fan control) supports two interfaces: 1) old /proc/i

Re: i8k: move driver from char to hwmon

2015-02-22 Thread Pali Rohár
On Sunday 22 February 2015 18:33:16 Guenter Roeck wrote: > On 02/22/2015 03:50 AM, Pali Rohár wrote: > > Hello, > > > > currently i8k driver for DELLDIAG SMM operations (charger, > > battery, hotkeys, temperature and fan control) supports two > > interfaces: > > > > 1) old /proc/i8k char device >

Re: i8k: move driver from char to hwmon

2015-02-22 Thread Guenter Roeck
On 02/22/2015 03:50 AM, Pali Rohár wrote: Hello, currently i8k driver for DELLDIAG SMM operations (charger, battery, hotkeys, temperature and fan control) supports two interfaces: 1) old /proc/i8k char device 2) new hwmon interface Driver now lives in char subsystem, but nowadays I think lot o