Re: general protection fault in qdisc_put

2019-09-09 Thread Cong Wang
On Sun, Sep 8, 2019 at 10:19 AM Linus Torvalds wrote: > I see two solutions: > > (a) move the > > q->qdisc = &noop_qdisc; > > up earlier in sfb_init(), so that qdisc is always initialized > after sfb_init(), even on failure. > > (b) just make qdisc_put(NULL) just silently work as a

Re: general protection fault in qdisc_put

2019-09-08 Thread Dmitry Vyukov
On Sun, Sep 8, 2019 at 6:19 PM Linus Torvalds wrote: > > On Sat, Sep 7, 2019 at 11:08 PM syzbot > wrote: > > > > The bug was bisected to: > > > > commit e41d58185f1444368873d4d7422f7664a68be61d > > Author: Dmitry Vyukov > > Date: Wed Jul 12 21:34:35 2017 + > > > > fault-inject: suppor

Re: general protection fault in qdisc_put

2019-09-08 Thread Linus Torvalds
On Sat, Sep 7, 2019 at 11:08 PM syzbot wrote: > > The bug was bisected to: > > commit e41d58185f1444368873d4d7422f7664a68be61d > Author: Dmitry Vyukov > Date: Wed Jul 12 21:34:35 2017 + > > fault-inject: support systematic fault injection That commit does seem a bit questionable, but