Re: ext2 inode size (on-disk)

2001-04-19 Thread Alexander Viro
On Thu, 19 Apr 2001, Andreas Dilger wrote: > Strange, I run "mke2fs -I 192 /dev/hdc2" and do not have a segfault or any > problems with e2fsck or debugfs on the resulting filesystem. I'm running > 1.20-WIP, but I don't think anything was changed in this area for some time. May depend on the

Re: ext2 inode size (on-disk)

2001-04-19 Thread Andreas Dilger
Al writes: > > I had always assumed that it would be a power-of-two size, but since it > > is an undocumented option to mke2fs, I suppose it was never really > > intended to be used. It appears, however, that the mke2fs code > > doesn't do ANY checking on the parameter, so you could concievably m

Re: ext2 inode size (on-disk)

2001-04-19 Thread Alexander Viro
On Thu, 19 Apr 2001, Andreas Dilger wrote: > Al, you write: > > Erm... Folks, can ->s_inode_size be not a power of 2? Both > > libext2fs and kernel break in that case. Example: > > > > dd if=/dev/zero of=foo bs=1024 count=20480 > > mkfs -I 192 foo > > I had always assumed that it would be

Re: ext2 inode size (on-disk)

2001-04-19 Thread Andreas Dilger
Al, you write: > Erm... Folks, can ->s_inode_size be not a power of 2? Both > libext2fs and kernel break in that case. Example: > > dd if=/dev/zero of=foo bs=1024 count=20480 > mkfs -I 192 foo I had always assumed that it would be a power-of-two size, but since it is an undocumented option