Re: dmapool regression in next

2018-12-06 Thread Stephen Rothwell
Hi all, On Thu, 6 Dec 2018 08:33:15 -0800 Tony Lindgren wrote: > > * Tony Battersby [181206 16:13]: > > On 12/6/18 10:51 AM, Robin Murphy wrote: > > >> Here is the prototype: > > >> > > >> void dma_pool_free(struct dma_pool *pool, void *vaddr, dma_addr_t dma); > > >> > > >> With the old code,

Re: dmapool regression in next

2018-12-06 Thread Tony Lindgren
* Tony Battersby [181206 16:13]: > On 12/6/18 10:51 AM, Robin Murphy wrote: > >> Here is the prototype: > >> > >> void dma_pool_free(struct dma_pool *pool, void *vaddr, dma_addr_t dma); > >> > >> With the old code, the 'dma' value had to be correct for use with > >> pool_find_page(), or else you w

Re: dmapool regression in next

2018-12-06 Thread Tony Battersby
On 12/6/18 10:51 AM, Robin Murphy wrote: >> Here is the prototype: >> >> void dma_pool_free(struct dma_pool *pool, void *vaddr, dma_addr_t dma); >> >> With the old code, the 'dma' value had to be correct for use with >> pool_find_page(), or else you would get an error.  If the 'vaddr' value >> was

Re: dmapool regression in next

2018-12-06 Thread Robin Murphy
On 06/12/2018 15:11, Tony Battersby wrote: On 12/6/18 4:25 AM, Krzysztof Kozlowski wrote: On Thu, 6 Dec 2018 at 02:31, Tony Lindgren wrote: Hi, Looks like with commit 26abe88e830d ("mm/dmapool.c: improve scalability of dma_pool_free()") I'm now getting spammed with lots of "(bad vaddr)" on at

Re: dmapool regression in next

2018-12-06 Thread Tony Battersby
On 12/6/18 4:25 AM, Krzysztof Kozlowski wrote: > On Thu, 6 Dec 2018 at 02:31, Tony Lindgren wrote: >> Hi, >> >> Looks like with commit 26abe88e830d ("mm/dmapool.c: improve scalability >> of dma_pool_free()") I'm now getting spammed with lots of "(bad vaddr)" >> on at least omap4 pandaboard, see be

Re: dmapool regression in next

2018-12-06 Thread Krzysztof Kozlowski
On Thu, 6 Dec 2018 at 02:31, Tony Lindgren wrote: > > Hi, > > Looks like with commit 26abe88e830d ("mm/dmapool.c: improve scalability > of dma_pool_free()") I'm now getting spammed with lots of "(bad vaddr)" > on at least omap4 pandaboard, see below. > > Any ideas what might be going wrong? > > Re