Re: dm-crypt performance

2013-03-28 Thread Tejun Heo
Hello, On Thu, Mar 28, 2013 at 04:38:08PM -0400, Vivek Goyal wrote: > If timing of unordered IO is an issue, then dm-crypt can try > to batch IO submission using blk_start_plug()/blk_finish_plug(). That way > dm-crypt can batch bio and control submission and there should not > be a need to put spe

Re: dm-crypt performance

2013-03-28 Thread Vivek Goyal
On Thu, Mar 28, 2013 at 12:44:43PM -0700, Tejun Heo wrote: > Hello, > > On Thu, Mar 28, 2013 at 03:33:43PM -0400, Vivek Goyal wrote: > > I am curious why out of order bio is a problem. Doesn't the elevator > > already merge bio's with existing requests and if merging does not > > happen then reque

Re: dm-crypt performance

2013-03-28 Thread Tejun Heo
Hello, On Thu, Mar 28, 2013 at 03:33:43PM -0400, Vivek Goyal wrote: > I am curious why out of order bio is a problem. Doesn't the elevator > already merge bio's with existing requests and if merging does not > happen then requests are sorted in order. So why ordering is not > happening properly wi

Re: dm-crypt performance

2013-03-28 Thread Vivek Goyal
On Thu, Mar 28, 2013 at 11:53:27AM -0700, Tejun Heo wrote: > Hello, > > (cc'ing Vivek and Jens for the iosched related bits) > > On Tue, Mar 26, 2013 at 04:28:38PM -0400, Mike Snitzer wrote: > > On Tue, Mar 26 2013 at 4:05pm -0400, > > Milan Broz wrote: > > > > > >On Mon, Mar 25, 2013 at 11:47

Re: dm-crypt performance

2013-03-28 Thread Tejun Heo
Hello, (cc'ing Vivek and Jens for the iosched related bits) On Tue, Mar 26, 2013 at 04:28:38PM -0400, Mike Snitzer wrote: > On Tue, Mar 26 2013 at 4:05pm -0400, > Milan Broz wrote: > > > >On Mon, Mar 25, 2013 at 11:47:22PM -0400, Mikulas Patocka wrote: > > > > > >>For best performance we could

Re: dm-crypt performance

2013-03-26 Thread Milan Broz
On 26.3.2013 21:28, Mike Snitzer wrote: On Tue, Mar 26 2013 at 4:05pm -0400, Milan Broz wrote: On Mon, Mar 25, 2013 at 11:47:22PM -0400, Mikulas Patocka wrote: For best performance we could use the unbound workqueue implementation with request sorting, if people don't object to the request

Re: dm-crypt performance

2013-03-26 Thread Mike Snitzer
On Tue, Mar 26 2013 at 4:05pm -0400, Milan Broz wrote: > >On Mon, Mar 25, 2013 at 11:47:22PM -0400, Mikulas Patocka wrote: > > > >>For best performance we could use the unbound workqueue implementation > >>with request sorting, if people don't object to the request sorting being > >>done in dm-c