Re: dm-bufio: fix memleak when using a dm_buffer's inline bio

2014-12-01 Thread Mike Snitzer
On Mon, Dec 01 2014 at 11:23am -0500, Mikulas Patocka wrote: > > > On Tue, 25 Nov 2014, Darrick J. Wong wrote: > > > When dm-bufio sets out to use the bio built into a struct dm_buffer to > > issue an IO, it needs to call bio_reset after it's done with the bio > > so that we can free things at

Re: dm-bufio: fix memleak when using a dm_buffer's inline bio

2014-11-26 Thread Mike Snitzer
On Wed, Nov 26 2014 at 9:28am -0500, Mike Snitzer wrote: > > But in the context of bufio's embedded bio, using .bi_private seems > fine. Just needs a comment. I'll fixup and get your patch staged (and > will CC stable). Staged for 3.19, see: https://git.kernel.org/cgit/linux/kernel/git/devic

Re: dm-bufio: fix memleak when using a dm_buffer's inline bio

2014-11-26 Thread Mike Snitzer
On Tue, Nov 25 2014 at 11:00pm -0500, Darrick J. Wong wrote: > On Tue, Nov 25, 2014 at 10:41:04PM -0500, Mike Snitzer wrote: > > On Tue, Nov 25 2014 at 8:45pm -0500, > > Darrick J. Wong wrote: > > > > > When dm-bufio sets out to use the bio built into a struct dm_buffer to > > > issue an IO, i

Re: dm-bufio: fix memleak when using a dm_buffer's inline bio

2014-11-25 Thread Mike Snitzer
On Tue, Nov 25 2014 at 8:45pm -0500, Darrick J. Wong wrote: > When dm-bufio sets out to use the bio built into a struct dm_buffer to > issue an IO, it needs to call bio_reset after it's done with the bio > so that we can free things attached to the bio such as the integrity > payload. Therefore