Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Takashi Iwai
At Tue, 9 Jul 2013 23:06:05 +0800, Ming Lei wrote: > > On Tue, Jul 9, 2013 at 10:45 PM, Takashi Iwai wrote: > > At Tue, 9 Jul 2013 22:39:36 +0800, > > Ming Lei wrote: > >> > >> On Tue, Jul 9, 2013 at 9:32 PM, Takashi Iwai wrote: > >> > At Tue, 9 Jul 2013 16:43:30 +0800, > >> >> Actually from vie

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Takashi Iwai
At Tue, 9 Jul 2013 23:22:33 +0800, Ming Lei wrote: > > On Tue, Jul 9, 2013 at 11:13 PM, Takashi Iwai wrote: > >> > >> The only cost of built-in user helper code is ~6Kbytes code on my armv7 > >> box. > >> > >> If the 6KB memory does mater for this non-distro kernel, we can introduce > >> more opt

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Ming Lei
On Tue, Jul 9, 2013 at 11:13 PM, Takashi Iwai wrote: >> >> The only cost of built-in user helper code is ~6Kbytes code on my armv7 >> box. >> >> If the 6KB memory does mater for this non-distro kernel, we can introduce >> more options. > > Well, if it doesn't matter, we don't need CONFIG_FW_LOADER

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Ming Lei
On Tue, Jul 9, 2013 at 10:45 PM, Takashi Iwai wrote: > At Tue, 9 Jul 2013 22:39:36 +0800, > Ming Lei wrote: >> >> On Tue, Jul 9, 2013 at 9:32 PM, Takashi Iwai wrote: >> > At Tue, 9 Jul 2013 16:43:30 +0800, >> >> Actually from view of distribution, dell rbu has to be compiled in, then >> >> no cod

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Takashi Iwai
At Tue, 9 Jul 2013 22:39:36 +0800, Ming Lei wrote: > > On Tue, Jul 9, 2013 at 9:32 PM, Takashi Iwai wrote: > > At Tue, 9 Jul 2013 16:43:30 +0800, > >> Actually from view of distribution, dell rbu has to be compiled in, then > >> no code size can be saved any more, which means looks the introduced

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Ming Lei
On Tue, Jul 9, 2013 at 9:32 PM, Takashi Iwai wrote: > At Tue, 9 Jul 2013 16:43:30 +0800, >> Actually from view of distribution, dell rbu has to be compiled in, then >> no code size can be saved any more, which means looks the introduced >> option in this patch isn't necessary. > > Well, but it mea

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Takashi Iwai
At Tue, 9 Jul 2013 16:43:30 +0800, Ming Lei wrote: > > On Tue, Jul 9, 2013 at 1:33 PM, Takashi Iwai wrote: > > At Tue, 9 Jul 2013 11:15:20 +0800, > > Ming Lei wrote: > >> > >> On Mon, Jul 8, 2013 at 5:05 PM, Takashi Iwai wrote: > >> > At Sat, 6 Jul 2013 15:30:03 -0700, > >> > Greg KH wrote: > >>

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-09 Thread Ming Lei
On Tue, Jul 9, 2013 at 1:33 PM, Takashi Iwai wrote: > At Tue, 9 Jul 2013 11:15:20 +0800, > Ming Lei wrote: >> >> On Mon, Jul 8, 2013 at 5:05 PM, Takashi Iwai wrote: >> > At Sat, 6 Jul 2013 15:30:03 -0700, >> > Greg KH wrote: >> >> >> >> On Sat, Jul 06, 2013 at 06:14:01PM -0400, Dave Jones wrote:

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-08 Thread Takashi Iwai
At Tue, 9 Jul 2013 11:15:20 +0800, Ming Lei wrote: > > On Mon, Jul 8, 2013 at 5:05 PM, Takashi Iwai wrote: > > At Sat, 6 Jul 2013 15:30:03 -0700, > > Greg KH wrote: > >> > >> On Sat, Jul 06, 2013 at 06:14:01PM -0400, Dave Jones wrote: > >> > On Tue, Jul 02, 2013 at 07:27:49PM +, Linux Kernel

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-08 Thread Ming Lei
On Mon, Jul 8, 2013 at 5:05 PM, Takashi Iwai wrote: > At Sat, 6 Jul 2013 15:30:03 -0700, > Greg KH wrote: >> >> On Sat, Jul 06, 2013 at 06:14:01PM -0400, Dave Jones wrote: >> > On Tue, Jul 02, 2013 at 07:27:49PM +, Linux Kernel wrote: >> > > Gitweb: >> > http://git.kernel.org/linus/;a=co

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-08 Thread Takashi Iwai
At Mon, 8 Jul 2013 09:49:33 -0700, Greg KH wrote: > > On Mon, Jul 08, 2013 at 11:05:20AM +0200, Takashi Iwai wrote: > > The reason is that dell_rbu driver requires it. Without the kconfig > > option, this driver won't work at all. So, it's a right fix for > > dell_rbu. > > > > AFAIK, the consen

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-08 Thread Greg KH
On Mon, Jul 08, 2013 at 11:05:20AM +0200, Takashi Iwai wrote: > The reason is that dell_rbu driver requires it. Without the kconfig > option, this driver won't work at all. So, it's a right fix for > dell_rbu. > > AFAIK, the consensus in the kernel side is that this too long fw > loading time is

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-08 Thread Takashi Iwai
At Sat, 6 Jul 2013 15:30:03 -0700, Greg KH wrote: > > On Sat, Jul 06, 2013 at 06:14:01PM -0400, Dave Jones wrote: > > On Tue, Jul 02, 2013 at 07:27:49PM +, Linux Kernel wrote: > > > Gitweb: > > http://git.kernel.org/linus/;a=commit;h=d05c39ea67f5786a549ac9d672d2951992b658c6 > > > Commit

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-06 Thread Greg KH
On Sat, Jul 06, 2013 at 06:14:01PM -0400, Dave Jones wrote: > On Tue, Jul 02, 2013 at 07:27:49PM +, Linux Kernel wrote: > > Gitweb: > http://git.kernel.org/linus/;a=commit;h=d05c39ea67f5786a549ac9d672d2951992b658c6 > > Commit: d05c39ea67f5786a549ac9d672d2951992b658c6 > > Parent:

Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly

2013-07-06 Thread Dave Jones
On Tue, Jul 02, 2013 at 07:27:49PM +, Linux Kernel wrote: > Gitweb: > http://git.kernel.org/linus/;a=commit;h=d05c39ea67f5786a549ac9d672d2951992b658c6 > Commit: d05c39ea67f5786a549ac9d672d2951992b658c6 > Parent: a3b2c8c7aa1ca860edcf0b0afa371d9eb2269c3c > Author: Takashi Iw