Re: checkpatch: false positive "does MAINTAINERS need updating?" warning

2019-10-06 Thread Joe Perches
On Mon, 2019-10-07 at 13:44 +0900, Masahiro Yamada wrote: > Hi Joe, > > > I ran checkpatch.pl against the following: > https://lore.kernel.org/patchwork/patch/1136334/ > > > I did update MAINTAINERS, but I still get > "does MAINTAINERS need updating?" warning. > Why? Because checkpatch is not

Re: checkpatch false positive (IMO): typo detected in truncated commit message

2018-06-25 Thread Joe Perches
On Mon, 2018-06-25 at 17:49 +0200, Jann Horn wrote: > On Mon, Jun 25, 2018 at 5:37 PM Joe Perches wrote: > > > > On Mon, 2018-06-25 at 17:32 +0200, Jann Horn wrote: > > > On Mon, Jun 25, 2018 at 5:23 PM Joe Perches wrote: > > > > > > > > On Mon, 2018-06-25 at 17:22 +0200, Jann Horn wrote: > > >

Re: checkpatch false positive (IMO): typo detected in truncated commit message

2018-06-25 Thread Jann Horn
On Mon, Jun 25, 2018 at 5:37 PM Joe Perches wrote: > > On Mon, 2018-06-25 at 17:32 +0200, Jann Horn wrote: > > On Mon, Jun 25, 2018 at 5:23 PM Joe Perches wrote: > > > > > > On Mon, 2018-06-25 at 17:22 +0200, Jann Horn wrote: > > > > Hello! > > > > > > > > I got the following message from checkpa

Re: checkpatch false positive (IMO): typo detected in truncated commit message

2018-06-25 Thread Joe Perches
On Mon, 2018-06-25 at 17:32 +0200, Jann Horn wrote: > On Mon, Jun 25, 2018 at 5:23 PM Joe Perches wrote: > > > > On Mon, 2018-06-25 at 17:22 +0200, Jann Horn wrote: > > > Hello! > > > > > > I got the following message from checkpatch: > > > > > > === > > > $ scripts/checkpatch.pl > > > 0001

Re: checkpatch false positive (IMO): typo detected in truncated commit message

2018-06-25 Thread Jann Horn
On Mon, Jun 25, 2018 at 5:23 PM Joe Perches wrote: > > On Mon, 2018-06-25 at 17:22 +0200, Jann Horn wrote: > > Hello! > > > > I got the following message from checkpatch: > > > > === > > $ scripts/checkpatch.pl > > 0001-netfilter-nf_log-don-t-hold-nf_log_mutex-during-user.patch > > WARNING: 'c

Re: checkpatch false positive (IMO): typo detected in truncated commit message

2018-06-25 Thread Joe Perches
On Mon, 2018-06-25 at 17:22 +0200, Jann Horn wrote: > Hello! > > I got the following message from checkpatch: > > === > $ scripts/checkpatch.pl > 0001-netfilter-nf_log-don-t-hold-nf_log_mutex-during-user.patch > WARNING: 'calle' may be misspelled - perhaps 'called'? > #15: > Fixes: 266d07cb1c

Re: Checkpatch: False positive

2015-07-16 Thread Andy Whitcroft
On Thu, Jul 16, 2015 at 08:58:56AM -0700, Joe Perches wrote: > On Thu, 2015-07-16 at 16:43 +0100, Andy Whitcroft wrote: > > On Thu, Jul 16, 2015 at 08:35:58AM -0700, Joe Perches wrote: > > > > #31: > > > > arch/x86/kernel/hpet.c | 198 > > > > ++--- > >

Re: Checkpatch: False positive

2015-07-16 Thread Joe Perches
On Thu, 2015-07-16 at 16:43 +0100, Andy Whitcroft wrote: > On Thu, Jul 16, 2015 at 08:35:58AM -0700, Joe Perches wrote: > > > #31: > > > arch/x86/kernel/hpet.c | 198 > > > ++--- > > I guess those are in the limbo land between the end of message and >

Re: Checkpatch: False positive

2015-07-16 Thread Andy Whitcroft
On Thu, Jul 16, 2015 at 08:35:58AM -0700, Joe Perches wrote: > > #31: > > arch/x86/kernel/hpet.c | 198 > > ++--- I guess those are in the limbo land between the end of message and beginning of the patch itself. Perhaps the test should at least stop a

Re: Checkpatch: False positive

2015-07-16 Thread Joe Perches
On Thu, 2015-07-16 at 16:25 +0530, Viresh Kumar wrote: > Hi Andy/Joe, > > I got a warning today for my cover-letter, and it looked like a false > positive. Please have a look, based of v4.2-rc2. > --- > -cover-letter.patch > --- > WARNING: Possible unwra

Re: checkpatch false positive

2014-10-21 Thread Hans de Goede
Hi, On 10/21/2014 10:28 AM, Joe Perches wrote: > On Tue, 2014-10-21 at 10:14 +0200, Hans de Goede wrote: >> Hi, >> >> Checkpatch gives the following warning: >> >> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? >> #31: >> new file mode 100644 >> >> total: 0 errors, 1 war

Re: checkpatch false positive

2014-10-21 Thread Joe Perches
On Tue, 2014-10-21 at 10:14 +0200, Hans de Goede wrote: > Hi, > > Checkpatch gives the following warning: > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #31: > new file mode 100644 > > total: 0 errors, 1 warnings, 352 lines checked > > 0001-input-Add-new-sun4i-l