Re: checkpatch error

2019-10-08 Thread Joe Perches
On Tue, 2019-10-08 at 12:02 +0800, Zhenzhong Duan wrote: > Hi, > > When I run checkpatch.pl with a patch doing reverting operation, it > reports a false positive error, Should I ignore the error or it's a bug? Ignore it.

Re: Checkpatch error on trace events macros

2013-07-29 Thread Li Zefan
On 2013/7/30 11:10, Joe Perches wrote: > On Tue, 2013-07-30 at 11:04 +0800, Li Zefan wrote: >> On 2013/7/30 10:36, Joe Perches wrote: >>> On Tue, 2013-07-30 at 10:06 +0800, Li Zefan wrote: On 2013/7/30 9:58, Joe Perches wrote: > So what are these TRACE_ defines that need > excluding fr

Re: Checkpatch error on trace events macros

2013-07-29 Thread Joe Perches
On Tue, 2013-07-30 at 11:04 +0800, Li Zefan wrote: > On 2013/7/30 10:36, Joe Perches wrote: > > On Tue, 2013-07-30 at 10:06 +0800, Li Zefan wrote: > >> On 2013/7/30 9:58, Joe Perches wrote: > >>> So what are these TRACE_ defines that need > >>> excluding from the "complex values" check? > >>> > >>>

Re: Checkpatch error on trace events macros

2013-07-29 Thread Li Zefan
On 2013/7/30 10:36, Joe Perches wrote: > On Tue, 2013-07-30 at 10:06 +0800, Li Zefan wrote: >> On 2013/7/30 9:58, Joe Perches wrote: >>> So what are these TRACE_ defines that need >>> excluding from the "complex values" check? >>> >>> Anything other than >>> >>> TRACE_SYSTEM >>> TRACE_INCLUDE_FILE

Re: Checkpatch error on trace events macros

2013-07-29 Thread Joe Perches
On Tue, 2013-07-30 at 10:06 +0800, Li Zefan wrote: > On 2013/7/30 9:58, Joe Perches wrote: > > So what are these TRACE_ defines that need > > excluding from the "complex values" check? > > > > Anything other than > > > > TRACE_SYSTEM > > TRACE_INCLUDE_FILE > > TRACE_INCLUDE_PATH > > > > ? > >

Re: Checkpatch error on trace events macros

2013-07-29 Thread Li Zefan
On 2013/7/30 9:58, Joe Perches wrote: > On Tue, 2013-07-30 at 09:30 +0800, Li Zefan wrote: >> On 2013/7/30 3:52, Sarah Sharp wrote: >>> Hi Andy and Joe, >>> >>> Checkpatch is complaining when code adds new trace events macros: >>> >>> sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/

Re: Checkpatch error on trace events macros

2013-07-29 Thread Joe Perches
On Tue, 2013-07-30 at 09:30 +0800, Li Zefan wrote: > On 2013/7/30 3:52, Sarah Sharp wrote: > > Hi Andy and Joe, > > > > Checkpatch is complaining when code adds new trace events macros: > > > > sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply > > Applying: xhci: add trace

Re: Checkpatch error on trace events macros

2013-07-29 Thread Li Zefan
On 2013/7/30 3:52, Sarah Sharp wrote: > Hi Andy and Joe, > > Checkpatch is complaining when code adds new trace events macros: > > sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply > Applying: xhci: add traces for debug messages in xhci_address_device() > ERROR: Macros wit

Re: Checkpatch error on trace events macros

2013-07-29 Thread Joe Perches
On Mon, 2013-07-29 at 14:23 -0700, Sarah Sharp wrote: > On Mon, Jul 29, 2013 at 01:02:44PM -0700, Joe Perches wrote: > > On Mon, 2013-07-29 at 12:52 -0700, Sarah Sharp wrote: [] > > > sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply > > > Applying: xhci: add traces for debu

Re: Checkpatch error on trace events macros

2013-07-29 Thread Sarah Sharp
On Mon, Jul 29, 2013 at 01:02:44PM -0700, Joe Perches wrote: > On Mon, 2013-07-29 at 12:52 -0700, Sarah Sharp wrote: > > Hi Andy and Joe, > > Hi Sarah. > > > Checkpatch is complaining when code adds new trace events macros: > > > > sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/

Re: Checkpatch error on trace events macros

2013-07-29 Thread Joe Perches
On Mon, 2013-07-29 at 12:52 -0700, Sarah Sharp wrote: > Hi Andy and Joe, Hi Sarah. > Checkpatch is complaining when code adds new trace events macros: > > sarah@xanatos:~/git/kernels/xhci$ git am -s ~/Maildir.fetchmail/.to-apply > Applying: xhci: add traces for debug messages in xhci_address_dev

Re: checkpatch: ERROR: Does not appear to be a unified-diff format patch

2007-10-13 Thread Andy Whitcroft
On Sat, Oct 13, 2007 at 02:55:01PM +0200, Jan Engelhardt wrote: > > On Oct 13 2007 14:47, Adrian Bunk wrote: > >On Sat, Oct 13, 2007 at 02:28:00PM +0200, Geert Uytterhoeven wrote: > >> scripts/checkpatch.pl doesn't seem to like this patch: > >> > >> $ scripts/checkpatch.pl m68k-export-asm-cachect

Re: checkpatch: ERROR: Does not appear to be a unified-diff format patch

2007-10-13 Thread Adrian Bunk
On Sat, Oct 13, 2007 at 02:55:01PM +0200, Jan Engelhardt wrote: > > On Oct 13 2007 14:47, Adrian Bunk wrote: > >On Sat, Oct 13, 2007 at 02:28:00PM +0200, Geert Uytterhoeven wrote: > >> scripts/checkpatch.pl doesn't seem to like this patch: > >> > >> $ scripts/checkpatch.pl m68k-export-asm-cachect

Re: checkpatch: ERROR: Does not appear to be a unified-diff format patch

2007-10-13 Thread Jan Engelhardt
On Oct 13 2007 14:47, Adrian Bunk wrote: >On Sat, Oct 13, 2007 at 02:28:00PM +0200, Geert Uytterhoeven wrote: >> scripts/checkpatch.pl doesn't seem to like this patch: >> >> $ scripts/checkpatch.pl m68k-export-asm-cachectl-h.diff >> ERROR: Does not appear to be a unified-diff format patch >>...

Re: checkpatch: ERROR: Does not appear to be a unified-diff format patch

2007-10-13 Thread Adrian Bunk
On Sat, Oct 13, 2007 at 02:28:00PM +0200, Geert Uytterhoeven wrote: > scripts/checkpatch.pl doesn't seem to like this patch: > > $ scripts/checkpatch.pl m68k-export-asm-cachectl-h.diff > ERROR: Does not appear to be a unified-diff format patch >... > --- a/include/asm-m68k/Kbuild > +++ b/include/