Re: checkpatch: comparisons with a constant on the left

2019-10-20 Thread Sergey Senozhatsky
On (10/10/19 20:23), Joe Perches wrote: > On Fri, 2019-10-11 at 10:52 +0900, Sergey Senozhatsky wrote: > > Hi Joe, > > Hi Sergey. Hi Joe, For some reason your reply triggered gmail spam filter; took me a while to notice and "recover" it from spam folder. [..] > > Both LINUX_VERSION_CODE and KER

Re: checkpatch: comparisons with a constant on the left

2019-10-10 Thread Joe Perches
On Fri, 2019-10-11 at 10:52 +0900, Sergey Senozhatsky wrote: > Hi Joe, Hi Sergey. > I noticed that this code > > #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 18, 0) > > triggers checkpatch's warning: > > "WARNING: Comparisons should place the constant on > the right