Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alain Knaff
>On Sat, 16 Sep 2000, Alain Knaff wrote: > >> >Flush >> >> What is so shocking about flushing away the cache for a >> write-protected floppy? > >Erm... The fact that final close() will do it anyway? Well it shouldn't, that would be a useless performance hit. > Oh, and the fact >that we have a g

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alexander Viro
On Sat, 16 Sep 2000, Alain Knaff wrote: > >You know, I have nothing against having it that way for CDs and Zips. > >And you have an interesting idea of old-fashioned - I'ld say that > >echo(1) was in place way before ioctl(2)... > > You're right, echo is indeed older than ioctl. However, ioct

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alain Knaff
> > >On Sat, 16 Sep 2000, Alain Knaff wrote: > >> Moreover you seem to have an interesting definition of "most": for >> many of those ioctls, sysctl would be rather clumsy: FDRAWCMD, >> FDSETPRM, FDCLRPRM, FDDEFPRM, FDFMTBEG, FDFMTTRK, FDFMTEND, FDFLUSH, >> FDRESET, FDTWADDLE, FDEJECT. Or do you r

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alain Knaff
> > >On Sat, 16 Sep 2000, Alain Knaff wrote: > >> Ok, now could you tell me a way how to easily detect a "fake inode", >> and I rewrite my "restore ioctl functionality patch" in a way as not >> to break floppy root mounts. > >s/root// > >fake means NULL ->i_sb, nothing fancy about that. IS_RDONLY(

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alexander Viro
On Sat, 16 Sep 2000, Alain Knaff wrote: > Moreover you seem to have an interesting definition of "most": for > many of those ioctls, sysctl would be rather clumsy: FDRAWCMD, > FDSETPRM, FDCLRPRM, FDDEFPRM, FDFMTBEG, FDFMTTRK, FDFMTEND, FDFLUSH, > FDRESET, FDTWADDLE, FDEJECT. Or do you really me

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alain Knaff
> > >On Sat, 16 Sep 2000, Alain Knaff wrote: > >> >Probably the clean solution would be to add a character device per >> >controller (/dev/fdc), turning eject /dev/fd0 into >> >% echo eject 0 > /dev/fdc0 >> >> Why do that for floppies, when we still eject CD-Roms, Zips, "the >> old-fashioned way"

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alexander Viro
On Sat, 16 Sep 2000, Alain Knaff wrote: > >Probably the clean solution would be to add a character device per > >controller (/dev/fdc), turning eject /dev/fd0 into > >% echo eject 0 > /dev/fdc0 > > Why do that for floppies, when we still eject CD-Roms, Zips, "the > old-fashioned way" with ioct

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alexander Viro
On Sat, 16 Sep 2000, Alain Knaff wrote: > >Flush > > What is so shocking about flushing away the cache for a > write-protected floppy? Erm... The fact that final close() will do it anyway? Oh, and the fact that we have a generic ioctl() doing the same. > > and format on write-protected flopp

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alain Knaff
> > >On Sat, 16 Sep 2000, Alain Knaff wrote: > >> >FYI, here is a chunk of our conversation - I just realized that most of it >> >was private with AV and Linus so it is reasonable that you didn't see it. >> >> Thanks for mailing me this. Well, I would have actually preferred to >> take part in th

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alexander Viro
On Sat, 16 Sep 2000, Alain Knaff wrote: > Ok, now could you tell me a way how to easily detect a "fake inode", > and I rewrite my "restore ioctl functionality patch" in a way as not > to break floppy root mounts. s/root// fake means NULL ->i_sb, nothing fancy about that. IS_RDONLY() used to b

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alexander Viro
On Sat, 16 Sep 2000, Alain Knaff wrote: > >FYI, here is a chunk of our conversation - I just realized that most of it > >was private with AV and Linus so it is reasonable that you didn't see it. > > Thanks for mailing me this. Well, I would have actually preferred to > take part in this discus

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Alain Knaff
EMAIL PROTECTED]>, Alexander Viro <[EMAIL PROTECTED]> >Subject: Re: bug in blkdev <-> VFS interaction. (oops) (fwd) > >On Sun, 6 Aug 2000, Linus Torvalds wrote: > >> So this is why I suggested moving the blkdev_get() into read_super(): at >> that point root moun

Re: bug in blkdev <-> VFS interaction. (oops) (fwd)

2000-09-16 Thread Tigran Aivazian
TED]> To: Linus Torvalds <[EMAIL PROTECTED]> Cc: Tigran Aivazian <[EMAIL PROTECTED]>, Alexander Viro <[EMAIL PROTECTED]> Subject: Re: bug in blkdev <-> VFS interaction. (oops) (fwd) On Sun, 6 Aug 2000, Linus Torvalds wrote: > So this is why I suggested moving the blk