Re: block: re-add discard_granularity and alignment checks

2015-10-27 Thread Jens Axboe
On 10/28/2015 06:23 AM, Ming Lin wrote: On Thu, Oct 22, 2015 at 10:03 AM, Mike Snitzer wrote: On Thu, Oct 22 2015 at 12:59pm -0400, Ming Lin wrote: From: Ming Lin In commit b49a087("block: remove split code in blkdev_issue_{discard,write_same}"), discard_granularity and alignment checks we

Re: block: re-add discard_granularity and alignment checks

2015-10-27 Thread Ming Lin
On Thu, Oct 22, 2015 at 10:03 AM, Mike Snitzer wrote: > On Thu, Oct 22 2015 at 12:59pm -0400, > Ming Lin wrote: > >> From: Ming Lin >> >> In commit b49a087("block: remove split code in >> blkdev_issue_{discard,write_same}"), discard_granularity and alignment >> checks were removed. Ideally, with

Re: block: re-add discard_granularity and alignment checks

2015-10-22 Thread Mike Snitzer
On Thu, Oct 22 2015 at 12:59pm -0400, Ming Lin wrote: > From: Ming Lin > > In commit b49a087("block: remove split code in > blkdev_issue_{discard,write_same}"), discard_granularity and alignment > checks were removed. Ideally, with bio late splitting, the upper layers > shouldn't need to depend