Re: block: flush queued bios when the process blocks

2015-10-06 Thread Mike Snitzer
On Tue, Oct 06 2015 at 2:17pm -0400, Mikulas Patocka wrote: > > > On Mon, 5 Oct 2015, Mike Snitzer wrote: > > > FYI, I've put rebased versions of your 2 patches in my wip branch, see: > > http://git.kernel.org/cgit/linux/kernel/git/snitzer/linux.git/log/?h=wip > > I found a bug in the first

Re: block: flush queued bios when the process blocks

2015-10-06 Thread Mikulas Patocka
On Tue, 6 Oct 2015, Mike Snitzer wrote: > On Tue, Oct 06 2015 at 9:28am -0400, > Mikulas Patocka wrote: > > > > > > > On Mon, 5 Oct 2015, Mike Snitzer wrote: > > > > > Mikulas, > > > > > > Could it be that cond_resched() wasn't unplugging? As was > > > recently raised in this thread: htt

Re: block: flush queued bios when the process blocks

2015-10-06 Thread Mikulas Patocka
On Tue, 6 Oct 2015, Mike Snitzer wrote: > On Tue, Oct 06 2015 at 9:28am -0400, > Mikulas Patocka wrote: > > > > > > > On Mon, 5 Oct 2015, Mike Snitzer wrote: > > > > > Mikulas, > > > > > > Could it be that cond_resched() wasn't unplugging? As was > > > recently raised in this thread: htt

Re: block: flush queued bios when the process blocks

2015-10-06 Thread Mike Snitzer
On Tue, Oct 06 2015 at 9:28am -0400, Mikulas Patocka wrote: > > > On Mon, 5 Oct 2015, Mike Snitzer wrote: > > > Mikulas, > > > > Could it be that cond_resched() wasn't unplugging? As was > > recently raised in this thread: https://lkml.org/lkml/2015/9/18/378 > > Chris Mason's patch from tha

Re: block: flush queued bios when the process blocks

2015-10-06 Thread Mikulas Patocka
On Mon, 5 Oct 2015, Mike Snitzer wrote: > Mikulas, > > Could it be that cond_resched() wasn't unplugging? As was > recently raised in this thread: https://lkml.org/lkml/2015/9/18/378 > Chris Mason's patch from that thread fixed this issue... I _think_ Linus > has since committed Chris' w

Re: block: flush queued bios when the process blocks

2015-10-05 Thread Mike Snitzer
On Thu, May 29 2014 at 7:52pm -0400, Mikulas Patocka wrote: > > > On Tue, 27 May 2014, Jens Axboe wrote: > > > On 2014-05-27 10:26, Mikulas Patocka wrote: > > > On Tue, 27 May 2014, Jens Axboe wrote: > > > > > > > On 2014-05-27 09:23, Mikulas Patocka wrote: > > > > > > > > > The patch adds

Re: block: flush queued bios when the process blocks

2015-10-05 Thread Mike Snitzer
On Tue, May 27 2014 at 3:56pm -0400, Kent Overstreet wrote: > On Tue, May 27, 2014 at 01:33:06PM -0400, Mike Snitzer wrote: > > On Tue, May 27 2014 at 12:26pm -0400, > > Mikulas Patocka wrote: > > > > > On Tue, 27 May 2014, Jens Axboe wrote: > > > > > > > On 2014-05-27 09:23, Mikulas Patocka

Re: block: flush queued bios when the process blocks

2014-05-27 Thread Kent Overstreet
On Tue, May 27, 2014 at 01:33:06PM -0400, Mike Snitzer wrote: > On Tue, May 27 2014 at 12:26pm -0400, > Mikulas Patocka wrote: > > > On Tue, 27 May 2014, Jens Axboe wrote: > > > > > On 2014-05-27 09:23, Mikulas Patocka wrote: > > > > > > > The patch adds bio list flushing to the scheduler just

Re: block: flush queued bios when the process blocks

2014-05-27 Thread Mike Snitzer
On Tue, May 27 2014 at 12:26pm -0400, Mikulas Patocka wrote: > On Tue, 27 May 2014, Jens Axboe wrote: > > > On 2014-05-27 09:23, Mikulas Patocka wrote: > > > > > The patch adds bio list flushing to the scheduler just besides plug > > > flushsing. > > > > ... which is exactly why I'm commenting