Re: block: correctly fallback for zeroout

2016-06-09 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: >> Userland apps rely on EOPNOTSUPP, we can't break that. Christoph> Rely on what exactly? Current we return EOPNOTSUPP if the Christoph> device doesn't claim to support discards, but it returns 0 if Christoph> the device first claims to support it

Re: block: correctly fallback for zeroout

2016-06-06 Thread Christoph Hellwig
On Mon, Jun 06, 2016 at 10:32:38PM -0400, Martin K. Petersen wrote: > > "Mike" == Mike Snitzer writes: > > Mike> But hch was originally in favor of _always_ dropping EOPNOTSUPP on > Mike> the floor (that is what his commit 38f25255330 did). Then he said > Mike> he disagrees with these interf

Re: block: correctly fallback for zeroout

2016-06-06 Thread Martin K. Petersen
> "Mike" == Mike Snitzer writes: Mike> But hch was originally in favor of _always_ dropping EOPNOTSUPP on Mike> the floor (that is what his commit 38f25255330 did). Then he said Mike> he disagrees with these interfaces playing games with masking Mike> EOPNOTSUPP -- to which you seemingly rea

Re: block: correctly fallback for zeroout

2016-06-02 Thread Mike Snitzer
On Thu, Jun 02 2016 at 11:06pm -0400, Martin K. Petersen wrote: > > "Christoph" == Christoph Hellwig writes: > > Christoph> As part of that I also removed the strange EOPNOTSUPP ignore, > Christoph> but Mike reverted it just because it changed something in the > Christoph> dm testsuite. >