Re: aic7xxx funcs without return values

2001-03-08 Thread Justin T. Gibbs
>The bigger problem with that driver for pedants is that it contains globals >with names like 'hard_error' which are asking for clashes . Bizarrely all >the static functions are carefully named ahc_* and the globals are called >things like 'restart_squencer' Such is the evolutionary nature of mos

Re: aic7xxx funcs without return values

2001-03-08 Thread Alan Cox
> They don't return a value because doing so is meaningless. You aren't > going to get past the panic. The compiler should know that assuming > panic is properly tagged as a function that cannot return. > > You may also want to check up on your C since having a break after > a return is, well,

Re: aic7xxx funcs without return values

2001-03-07 Thread Justin T. Gibbs
>Hi, > >Just a note to make gcc 2.96 (and future) happy. The aic7xxx driver is full of >inline funcs that should return a value and do not do that: They don't return a value because doing so is meaningless. You aren't going to get past the panic. The compiler should know that assuming panic is