Missed the 'send' button on this last night.
> -Original Message-
> From: Jiri Slaby [mailto:[EMAIL PROTECTED]
> Sent: Thursday, February 07, 2008 12:09 PM
> To: Stephen Neuendorffer; Grant Likely
> Cc: Linux Kernel Mailing List; Andrew Morton
> Subject: Xilinx: hwicap driver comments
>
>
On Thu, 7 Feb 2008 14:11:43 -0800
Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Thu, 7 Feb 2008 15:35:45 -0600
> Josh Boyer <[EMAIL PROTECTED]> wrote:
>
> > > Guys, can we all play too?
> >
> > Sure. You could add my tree to -mm if you want. Though I'd really
> > rather if we all sync up with
On 02/07/2008 11:31 PM, Stephen Neuendorffer wrote:
Few comments I have:
- release f_op retval is silently ignored, I guess you will get your
device into
undefined state when the first function fails (esp. when you interrupt
the sem)
Hmm.. hadn't realized that. I'm open to suggestions on ho
> -Original Message-
> From: Jiri Slaby [mailto:[EMAIL PROTECTED]
> Sent: Thursday, February 07, 2008 12:09 PM
> To: Stephen Neuendorffer; Grant Likely
> Cc: Linux Kernel Mailing List; Andrew Morton
> Subject: Xilinx: hwicap driver comments
>
> Hi,
>
> first of all, I think that the dri
On Thu, 7 Feb 2008 15:35:45 -0600
Josh Boyer <[EMAIL PROTECTED]> wrote:
> > Guys, can we all play too?
>
> Sure. You could add my tree to -mm if you want. Though I'd really
> rather if we all sync up with Paul sooner so you don't have to track 5
> or 6 "powerpc" trees.
Yes, I was trying to pul
> > I'm rather new to all this and still (to some extent) trying to
figure
> > out what is expected.
>
> We're all still trying to figure it out, really. We've gone and made
it
> awfully easy to get code into the kernel nowadays. Perhaps too easy.
I'm
> presently having a little campaign of wat
On Thu, 7 Feb 2008 13:35:09 -0800
"Stephen Neuendorffer" <[EMAIL PROTECTED]> wrote:
> > > It seems wrong that the signoff trail for that patch didn't actually
> > > reflect reality - it should have had both Josh's and Paul's
> signoffs. That
> > > would require that the changelog be altered durin
On Thu, 7 Feb 2008, Andrew Morton wrote:
>
> It seems wrong that the signoff trail for that patch didn't actually
> reflect reality - it should have had both Josh's and Paul's signoffs.
No, it's correct.
If you look deeper, you'll see (in gitk, or using "--pretty=fuller") that
it has:
On Thu, 7 Feb 2008 12:42:03 -0800
Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Thu, 07 Feb 2008 21:08:50 +0100
> Jiri Slaby <[EMAIL PROTECTED]> wrote:
>
> > first of all, I think that the driver should go through lkml before
> > upstream
> > merge or at least be in -mm for a while (I think thi
> > It seems wrong that the signoff trail for that patch didn't actually
> > reflect reality - it should have had both Josh's and Paul's
signoffs. That
> > would require that the changelog be altered during git->git
transfers which
> > I expect is just incompatible with the way git works (as far a
On 2/7/08, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
>
> On Thu, 2008-02-07 at 22:28 +0100, Jiri Slaby wrote:
> > Yup, should... [I don't know how ofter people have 64bit resources on 32 bit
> > this becomes a problem.]
>
> For MMIO it's becoming more and more common actually in the embedde
On Thu, 2008-02-07 at 22:28 +0100, Jiri Slaby wrote:
> On 02/07/2008 10:17 PM, Benjamin Herrenschmidt wrote:
> > On Thu, 2008-02-07 at 21:08 +0100, Jiri Slaby wrote:
> >> - io resources are at least ulong
> >
> > They should actually be resource_size_t :-)
>
> Yup, should... [I don't know how of
On 2/7/08, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Thu, 7 Feb 2008 13:54:06 -0700
> "Grant Likely" <[EMAIL PROTECTED]> wrote:
> >
> > It went through my tree. Paul pulls from Josh Boyer's tree for
> > powerpc-4xx patches, and Josh pulls from mine for xilinx virtex
> > powerpc 405 patches.
>
On 02/07/2008 10:17 PM, Benjamin Herrenschmidt wrote:
On Thu, 2008-02-07 at 21:08 +0100, Jiri Slaby wrote:
- io resources are at least ulong
They should actually be resource_size_t :-)
Yup, should... [I don't know how ofter people have 64bit resources on 32 bit
this becomes a problem.]
--
On Thu, 2008-02-07 at 13:54 -0700, Grant Likely wrote:
> On 2/7/08, Andrew Morton <[EMAIL PROTECTED]> wrote:
> > On Thu, 07 Feb 2008 21:08:50 +0100
> > How it got from there into Linux is also a mystery. I see a batch of
> > powerpc updates just went into mainline but I don't know whose tree was
On Thu, 7 Feb 2008 13:54:06 -0700
"Grant Likely" <[EMAIL PROTECTED]> wrote:
> On 2/7/08, Andrew Morton <[EMAIL PROTECTED]> wrote:
> > On Thu, 07 Feb 2008 21:08:50 +0100
> > How it got from there into Linux is also a mystery. I see a batch of
> > powerpc updates just went into mainline but I don't
On Thu, 2008-02-07 at 21:08 +0100, Jiri Slaby wrote:
> - io resources are at least ulong
They should actually be resource_size_t :-)
Ben.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger
> Stephen, can you please repost you patch to the LKML? Even if the
> driver is allowed to stay in for the time being you can at least get
> feedback on what needs to be changed.
Certainly... I'll try to address some of Jiri's issues first.
Steve
--
To unsubscribe from this list: send the li
On 2/7/08, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Thu, 07 Feb 2008 21:08:50 +0100
> How it got from there into Linux is also a mystery. I see a batch of
> powerpc updates just went into mainline but I don't know whose tree was
> pulled - I wasn't copied on any pull request and I can't find
On Thu, 07 Feb 2008 21:08:50 +0100
Jiri Slaby <[EMAIL PROTECTED]> wrote:
> first of all, I think that the driver should go through lkml before upstream
> merge or at least be in -mm for a while (I think this used to be a rule some
> time ago), correct me if I'm wrong, but none of it happened.
N
On 2/7/08, Jiri Slaby <[EMAIL PROTECTED]> wrote:
> Hi,
>
> first of all, I think that the driver should go through lkml before upstream
> merge or at least be in -mm for a while (I think this used to be a rule some
> time ago), correct me if I'm wrong, but none of it happened.
Hmmm, if that's the
21 matches
Mail list logo
