Re: WARNING: locking bug in nfs_get_client

2019-05-09 Thread Schumaker, Anna
On Thu, 2019-05-09 at 07:37 -0400, Benjamin Coddington wrote: > NetApp Security WARNING: This is an external email. Do not click links or open > attachments unless you recognize the sender and know the content is safe. > > > > > I think nfs_get_client and nfs_match_client could use a refactor..

Re: WARNING: locking bug in nfs_get_client

2019-05-09 Thread Benjamin Coddington
I think nfs_get_client and nfs_match_client could use a refactor.. but the trivial fix is: 8<- From 4ef2fc5912c5980890e781f8c0d941330254c100 Mon Sep 17 00:00:00 2001 Message-Id: <4ef2fc5912c5980890e781f8c0d941330254c100.1557401467.git.bcodd...@redhat.com> From:

Re: WARNING: locking bug in nfs_get_client

2019-05-09 Thread Benjamin Coddington
We need to return from nfs_match_client() while still holding the nfs_client_lock, or maybe fixed with ISERR_OR_NULL in nfs_match client(). Anna, would you like a patch to fix it, or can that commit be pulled out and fixed up at this point? Ben On 8 May 2019, at 20:17, syzbot wrote: Hell

Re: WARNING: locking bug in nfs_get_client

2019-05-08 Thread syzbot
syzbot has bisected this bug to: commit 950a578c6128c2886e295b9c7ecb0b6b22fcc92b Author: Roberto Bergantinos Corpas Date: Thu Apr 25 13:36:51 2019 + NFS: make nfs_match_client killable bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11e40aaca0 start commit: 31ccad9