Re: VM_RESERVED [was Re: mapping user space buffer to kernel address space]

2000-10-20 Thread Jeff Garzik
Andrea Arcangeli wrote: > > On Fri, Oct 20, 2000 at 02:19:59PM -0400, Jeff Garzik wrote: > > Why? [..] > > vma information isn't passed from v4l layer to lowlevel layer. so I see :( The Matrox Meteor II driver I'm developing uses DMA memory, PCI shared memory, -or- reserve_bootmem memory in mm

Re: VM_RESERVED [was Re: mapping user space buffer to kernel address space]

2000-10-20 Thread Andrea Arcangeli
On Fri, Oct 20, 2000 at 02:19:59PM -0400, Jeff Garzik wrote: > Why? [..] vma information isn't passed from v4l layer to lowlevel layer. Andrea - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www

Re: VM_RESERVED [was Re: mapping user space buffer to kernel address space]

2000-10-20 Thread Linus Torvalds
On Fri, 20 Oct 2000, Jeff Garzik wrote: > > If I understand your patch, I should call vma_reserve(), and then > completely remove my no-op swapout(). Correct? Note that I dislike "wrapper.h", and I just removed that part. I don't think it's any clearer to write "vma_reserve(vma)" than it is

Re: VM_RESERVED [was Re: mapping user space buffer to kernel address space]

2000-10-20 Thread Jeff Garzik
Andrea Arcangeli wrote: > On Fri, Oct 20, 2000 at 01:46:53PM -0400, Jeff Garzik wrote: > > In any case, we shouldn't modify videodev.c to call vma_reserve()... > > Let the driver's mmap operation do that or not do that, as it chooses. > > It can't with the current mmap video4linux kernel API. Wh

Re: VM_RESERVED [was Re: mapping user space buffer to kernel address space]

2000-10-20 Thread Andrea Arcangeli
On Fri, Oct 20, 2000 at 01:46:53PM -0400, Jeff Garzik wrote: > In any case, we shouldn't modify videodev.c to call vma_reserve()... > Let the driver's mmap operation do that or not do that, as it chooses. It can't with the current mmap video4linux kernel API. In practice it doesn't matter becau

Re: VM_RESERVED [was Re: mapping user space buffer to kernel address space]

2000-10-20 Thread Andrea Arcangeli
On Fri, Oct 20, 2000 at 10:44:40AM -0700, Linus Torvalds wrote: > agree with your change, but I just suspect it will break drivers that have you're right, it would break it, the driver should really somehow increase the pagecount for each mapping with the PG_reserved removed (in the future that c

Re: VM_RESERVED [was Re: mapping user space buffer to kernel address space]

2000-10-20 Thread Jeff Garzik
Andrea Arcangeli wrote: > > As to your rvmalloc()/rvfree() changes, I don't think they are safe as-is: > > I think it's the right thing to do, but I don't trust the drivers to > > maintain the right page counts. The code used to mark the pages as > > reserved, which probably means that it hides ba

Re: VM_RESERVED [was Re: mapping user space buffer to kernel address space]

2000-10-20 Thread Andrea Arcangeli
On Fri, Oct 20, 2000 at 10:10:05AM -0700, Linus Torvalds wrote: > Sure. I have no problem at all with this suggestion: it's basically just a > hint to the VM layer that trying to page something out in this vma is > useless, as its backing store is in memory anyway. Yes, that is _exactly_ the poin