On Sun, 22 Apr 2007, Junio C Hamano wrote:
>
> How about this as a replacement (hot off the press -- still
> running the tests).
Looks good, but..
> + mode_t mode = umask(0);
> +
> + umask(mode);
> + mode = 0666 & ~mode;
I would really suggest just defaulti
Junio C Hamano <[EMAIL PROTECTED]> writes:
> Linus Torvalds <[EMAIL PROTECTED]> writes:
>
>> So I think that if the user has a umask that says "nobody else can read",
>> then we should *not* make it world readable (unless the
>> "shared_repository" thing is set to override it, of course).
>
> I
Linus Torvalds <[EMAIL PROTECTED]> writes:
> On Sun, 22 Apr 2007, Nicolas Pitre wrote:
>>
>> Well, actually there is no point making pack files writable. If they're
>> modified, they get corrupted.
>>
>> Here's the fix I wanted to propose:
>>
>> diff --git a/builtin-pack-objects.c b/builtin-p
On Sun, 22 Apr 2007, Nicolas Pitre wrote:
>
> Well, actually there is no point making pack files writable. If they're
> modified, they get corrupted.
>
> Here's the fix I wanted to propose:
>
> diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
> index c72e07a..85c6e6e 100644
> ---
Nicolas Pitre <[EMAIL PROTECTED]> writes:
> On Sun, 22 Apr 2007, Nicolas Pitre wrote:
>
>> On Sun, 22 Apr 2007, Junio C Hamano wrote:
>>
>> > Nicolas Pitre <[EMAIL PROTECTED]> writes:
>> >
>> > > On Sun, 22 Apr 2007, Junio C Hamano wrote:
>> > >
>> > >> With recent glibc, mkstemp() creates 0400
On Sun, 22 Apr 2007, Nicolas Pitre wrote:
> On Sun, 22 Apr 2007, Junio C Hamano wrote:
>
> > Nicolas Pitre <[EMAIL PROTECTED]> writes:
> >
> > > On Sun, 22 Apr 2007, Junio C Hamano wrote:
> > >
> > >> With recent glibc, mkstemp() creates 0400 file. Updated
> > >> pack-objects uses it in pack/id
On Sun, 22 Apr 2007, Junio C Hamano wrote:
> Nicolas Pitre <[EMAIL PROTECTED]> writes:
>
> > On Sun, 22 Apr 2007, Junio C Hamano wrote:
> >
> >> With recent glibc, mkstemp() creates 0400 file. Updated
> >> pack-objects uses it in pack/idx writing without fixing this,
> >> hence this problem.
> >
Nicolas Pitre <[EMAIL PROTECTED]> writes:
> On Sun, 22 Apr 2007, Junio C Hamano wrote:
>
>> With recent glibc, mkstemp() creates 0400 file. Updated
>> pack-objects uses it in pack/idx writing without fixing this,
>> hence this problem.
>
> Oops. I guess I'm guilty for this. I didn't bother look
On Sun, 22 Apr 2007, Junio C Hamano wrote:
> With recent glibc, mkstemp() creates 0400 file. Updated
> pack-objects uses it in pack/idx writing without fixing this,
> hence this problem.
Oops. I guess I'm guilty for this. I didn't bother looking at the
permission on the pack for git-pack-obje
9 matches
Mail list logo
