Re: SyncPPP IPCP/LCP loop problem and patch

2001-05-24 Thread Alan Cox
> I did not realize that syncppp does not implement > all the RFC1661 states. That's simply broken :( > A proper state machine implementation would be nice. syncppp.c -predates- RFC1661 I believe. > On the other hand, it works in a minimal way > for most people and it's supposed to be folded > i

Re: SyncPPP IPCP/LCP loop problem and patch

2001-05-24 Thread Paul Fulghum
From: <[EMAIL PROTECTED]> > Linux syncppp does not have a LCP_STATE_REQ_SENT ... [snip] > Who's the owner for syncppp.c ? I might be able to put some time in on > it, but would hate to be sending patches into empty space. I'm not sure anyone is willing to claim ownership :) I did not realize t

Re: SyncPPP IPCP/LCP loop problem and patch

2001-05-24 Thread rjd
Paul Fulghum wrote: > > RFC1661 state table shows a transition to req-sent > from opened when a (properly formated with > correct sequence ID) cfg-ack is received. > > Syncppp does not do this (from sppp_lcp_input): ... > Maybe adding: > > case LCP_STATE_OPENED: >sppp_lcp_open (sp); >

Re: SyncPPP IPCP/LCP loop problem and patch

2001-05-22 Thread Paul Fulghum
> > Seems to me that when you get the conf-request in opened state, you > > should send your conf-request before sending the conf-ack to the > > peer's conf-request. I think this would short-circuit the loop (I > > could be wrong though, it's getting late). > > Thanks but I've already tried that

Re: SyncPPP IPCP/LCP loop problem and patch

2001-05-22 Thread Paul Fulghum
> > Seems to me that when you get the conf-request in opened state, you > > should send your conf-request before sending the conf-ack to the > > peer's conf-request. I think this would short-circuit the loop (I > > could be wrong though, it's getting late). > > Thanks but I've already tried that

Re: SyncPPP IPCP/LCP loop problem and patch

2001-05-22 Thread rjd
Paul Mackerras wrote: > > [EMAIL PROTECTED] writes: > > I've hit a problem with the syncPPP module within Linux. > > Seems to me that when you get the conf-request in opened state, you > should send your conf-request before sending the conf-ack to the > peer's conf-request. I think this would s

Re: SyncPPP IPCP/LCP loop problem and patch

2001-05-22 Thread Paul Mackerras
[EMAIL PROTECTED] writes: > I've hit a problem with the syncPPP module within Linux. > > Under certain conditions (hard to quantify exactly, but try several 8Mbps > streams hitting a relatively slow, say 200MHz processor) the LCP/IPCP > negotiation hits the following loop. [snip] > My solution