Re: Regression with wait_event_timeout in next-20140226

2014-04-09 Thread Andrew Morton
On Wed, 9 Apr 2014 13:16:38 +0200 Peter Zijlstra wrote: > On Wed, Feb 26, 2014 at 02:25:34PM -0800, Andrew Morton wrote: > > Is there anything we can do to make all this clearer? Simply using a > > distinctive variable name ("__wait_var__"?) in place of __ret (and > > documenting it) would help

Re: Regression with wait_event_timeout in next-20140226

2014-04-09 Thread Peter Zijlstra
On Wed, Feb 26, 2014 at 02:25:34PM -0800, Andrew Morton wrote: > Is there anything we can do to make all this clearer? Simply using a > distinctive variable name ("__wait_var__"?) in place of __ret (and > documenting it) would help a lot. > > Some __ret's are long and some are int. Maybe that's

Re: Regression with wait_event_timeout in next-20140226

2014-02-26 Thread Stephen Rothwell
Hi Peter, On Wed, 26 Feb 2014 17:50:43 +0100 Peter Zijlstra wrote: > > On Wed, Feb 26, 2014 at 05:35:19PM +0100, Gregory CLEMENT wrote: > > > > while testing next-20140226 I got an issue with the function > > wait_event_timeout. When this function timed out instead of returning > > 0, it returne

Re: Regression with wait_event_timeout in next-20140226

2014-02-26 Thread Peter Zijlstra
On Wed, Feb 26, 2014 at 02:25:34PM -0800, Andrew Morton wrote: > Is there anything we can do to make all this clearer? Simply using a > distinctive variable name ("__wait_var__"?) in place of __ret (and > documenting it) would help a lot. % s/\<__ret\>/__wait_var__/g should get you mostly there I

Re: Regression with wait_event_timeout in next-20140226

2014-02-26 Thread Andrew Morton
On Wed, 26 Feb 2014 17:50:43 +0100 Peter Zijlstra wrote: > On Wed, Feb 26, 2014 at 05:35:19PM +0100, Gregory CLEMENT wrote: > > Hi, > > > > while testing next-20140226 I got an issue with the function > > wait_event_timeout. When this function timed out instead of returning > > 0, it returned th

Re: Regression with wait_event_timeout in next-20140226

2014-02-26 Thread Peter Zijlstra
On Wed, Feb 26, 2014 at 05:35:19PM +0100, Gregory CLEMENT wrote: > Hi, > > while testing next-20140226 I got an issue with the function > wait_event_timeout. When this function timed out instead of returning > 0, it returned the value of the timeout passed in parameter. I found > that reverting "s