Re: Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-05-28 Thread Thomas Gleixner
Andi, Andi Kleen writes: >> Setting the fs register in userspace is an essential feature for running >> legacy code in SGX. We have been following LKML discussions on this >> instruction for years, and hoping this feature would be supported by Linux, > > If you need a feature you should comment

Re: Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-05-27 Thread Wojtek Porczyk
On Wed, May 27, 2020 at 11:20:08AM +0300, Jarkko Sakkinen wrote: > On Fri, 2020-05-22 at 16:14 -0400, Don Porter wrote: > > legacy code in SGX. We have been following LKML discussions on this > > instruction for years, and hoping this feature would be supported by > > Linux, so that we can retir

Re: Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-05-27 Thread Jarkko Sakkinen
On Sun, 2020-05-24 at 12:45 -0700, h...@zytor.com wrote: > On a related topic (needless to say, this should never have happened > and is being raised at the highest levels inside Intel): > > There are legitimate reasons to write a root-hole module, the main one > being able to test security featur

Re: Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-05-27 Thread Jarkko Sakkinen
On Fri, 2020-05-22 at 16:14 -0400, Don Porter wrote: > legacy code in SGX. We have been following LKML discussions on this > instruction for years, and hoping this feature would be supported by > Linux, so that we can retire this module. To our knowledge, every SGX Why have you followed this

RE: Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-05-26 Thread David Laight
From: Richard Weinberger > Sent: 25 May 2020 08:55 ... > P: Sadly too. Mostly because customer has custom module and forgot to set it > GPL You want us to lie that custom modules are GPL? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registra

Re: Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-05-25 Thread Richard Weinberger
On Sun, May 24, 2020 at 11:20 PM Sasha Levin wrote: > > On Sun, May 24, 2020 at 12:45:18PM -0700, h...@zytor.com wrote: > >There are legitimate reasons to write a root-hole module, the main one being > >able to test security features like SMAP. I have requested before a TAINT > >flag specificall

Re: Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-05-24 Thread hpa
On May 24, 2020 2:19:45 PM PDT, Sasha Levin wrote: >On Sun, May 24, 2020 at 12:45:18PM -0700, h...@zytor.com wrote: >>There are legitimate reasons to write a root-hole module, the main one >being able to test security features like SMAP. I have requested before >a TAINT flag specifically for this

Re: Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-05-24 Thread Sasha Levin
On Sun, May 24, 2020 at 12:45:18PM -0700, h...@zytor.com wrote: There are legitimate reasons to write a root-hole module, the main one being able to test security features like SMAP. I have requested before a TAINT flag specifically for this purpose, because TAINT_CRAP is nowhere near explicit

Re: Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-05-24 Thread hpa
On May 22, 2020 5:45:39 PM PDT, Thomas Gleixner wrote: >Don, > >Don Porter writes: >> On 5/19/20 12:48 PM, Jarkko Sakkinen wrote: >>> On Tue, May 19, 2020 at 01:03:25AM +0200, Thomas Gleixner wrote: That justifies to write books which recommend to load a kernel >module which create

Re: Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-05-22 Thread Andi Kleen
> Setting the fs register in userspace is an essential feature for running > legacy code in SGX. We have been following LKML discussions on this > instruction for years, and hoping this feature would be supported by Linux, If you need a feature you should comment on it. One of the reasons it took

Re: Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-05-22 Thread Thomas Gleixner
Don, Don Porter writes: > On 5/19/20 12:48 PM, Jarkko Sakkinen wrote: >> On Tue, May 19, 2020 at 01:03:25AM +0200, Thomas Gleixner wrote: >>> >>> That justifies to write books which recommend to load a kernel module >>> which creates a full unpriviledged root hole. I bet none of these papers >>>

Re: Re: [PATCH v12 00/18] Enable FSGSBASE instructions

2020-05-22 Thread Don Porter
On 5/19/20 12:48 PM, Jarkko Sakkinen wrote: On Tue, May 19, 2020 at 01:03:25AM +0200, Thomas Gleixner wrote: Jarkko Sakkinen writes: On Mon, 2020-05-18 at 08:34 -0700, Andi Kleen wrote: Yes, for SGX this is functional feature because enclave entry points, thread control structures (aka TCS's)