Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-03 Thread Maciej W. Rozycki
On Thu, 2 Aug 2007, Andrew Morton wrote: > > We could use that to prevent init code to be called after code is freed. > > If we can omit a function call without breaking anything then we shouldn't > have been calling that function at all ;) Well, we can always put a couple of otherwise unneeded

Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-03 Thread Daniel Ritz
On Friday 03 August 2007 02:18:10 Yinghai Lu wrote: > Andrew Morton wrote: > > On Thu, 02 Aug 2007 16:24:42 -0700 > > Yinghai Lu <[EMAIL PROTECTED]> wrote: > > > >> Daniel Ritz wrote: > >>> commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly > >>> with an oops, completely killin

Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Yinghai Lu
Andrew Morton wrote: On Thu, 02 Aug 2007 16:24:42 -0700 Yinghai Lu <[EMAIL PROTECTED]> wrote: Daniel Ritz wrote: commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly with an oops, completely killing PCMCIA. register_console() now calls console->early_setup(). which in case o

Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Andrew Morton
On Thu, 02 Aug 2007 16:24:42 -0700 Yinghai Lu <[EMAIL PROTECTED]> wrote: > Daniel Ritz wrote: > > commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly > > with an oops, completely killing PCMCIA. > > > > register_console() now calls console->early_setup(). which in case of > > 8

Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Yinghai Lu
Daniel Ritz wrote: commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly with an oops, completely killing PCMCIA. register_console() now calls console->early_setup(). which in case of 8250.c (the only user anyway) is serial8250_console_early_setup() which is __init, calling 8250

Re: REGRESSION: serial_cs broken by 8250 changes

2007-08-02 Thread Andrew Morton
On Fri, 3 Aug 2007 01:06:32 +0200 Daniel Ritz <[EMAIL PROTECTED]> wrote: > commit 18a8bd949d6adb311ea816125ff65050df1f3f6e breaks serial_cs badly > with an oops, completely killing PCMCIA. > > register_console() now calls console->early_setup(). which in case of > 8250.c (the only user anyway) is