Re: Print taint info in more places.

2007-12-14 Thread Dave Jones
On Fri, Dec 14, 2007 at 09:38:44AM -0600, Matt Mackall wrote: > On Thu, Dec 13, 2007 at 08:30:41PM -0500, Dave Jones wrote: > > #ifndef HAVE_ARCH_BUG > > #define BUG() do { \ > > - printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, > > __FUNCTION__); \ > > + printk(KERN_ERR "BUG

Re: Print taint info in more places.

2007-12-14 Thread Matt Mackall
On Thu, Dec 13, 2007 at 08:30:41PM -0500, Dave Jones wrote: > #ifndef HAVE_ARCH_BUG > #define BUG() do { \ > - printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, > __FUNCTION__); \ > + printk(KERN_ERR "BUG: failure at %s:%d/%s()! (%s)\n", > + __FILE__, __LINE__, __FU

Re: Print taint info in more places.

2007-12-14 Thread Jon Masters
On Thu, 2007-12-13 at 17:49 -0500, Dave Jones wrote: > We've found in the past that various bug reports have had minimal > information, just a few printk's rather than a complete oops, > and it's taken several round-trips with the bug reporter before > we've discovered they had some proprietary mo

Re: Print taint info in more places.

2007-12-13 Thread Dave Jones
On Thu, Dec 13, 2007 at 11:25:06PM -0800, Jeremy Fitzhardinge wrote: > Dave Jones wrote: > > On Fri, Dec 14, 2007 at 01:03:50AM +0100, Adrian Bunk wrote: > > > > > > #ifndef HAVE_ARCH_BUG > > > > #define BUG() do { \ > > > > - printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE_

Re: Print taint info in more places.

2007-12-13 Thread Jeremy Fitzhardinge
Dave Jones wrote: > On Fri, Dec 14, 2007 at 01:03:50AM +0100, Adrian Bunk wrote: > > > > #ifndef HAVE_ARCH_BUG > > > #define BUG() do { \ > > > -printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, > __FUNCTION__); \ > > > +printk(KERN_ERR "BUG: failure at %s:%d/%s()!

Re: Print taint info in more places.

2007-12-13 Thread Dave Jones
On Fri, Dec 14, 2007 at 01:03:50AM +0100, Adrian Bunk wrote: > > #ifndef HAVE_ARCH_BUG > > #define BUG() do { \ > > - printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, > > __FUNCTION__); \ > > + printk(KERN_ERR "BUG: failure at %s:%d/%s()! (%s)\n", > > + __FILE__, __L

Re: Print taint info in more places.

2007-12-13 Thread Dave Jones
On Fri, Dec 14, 2007 at 01:03:50AM +0100, Adrian Bunk wrote: > > #ifndef HAVE_ARCH_BUG > > #define BUG() do { \ > > - printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, > > __FUNCTION__); \ > > + printk(KERN_ERR "BUG: failure at %s:%d/%s()! (%s)\n", > > + __FILE__, __L

Re: Print taint info in more places.

2007-12-13 Thread Dave Jones
On Thu, Dec 13, 2007 at 06:52:42PM -0500, Dave Jones wrote: > > Have you checked how this affects code size? It might be worth it > > now to do a out of line helper. > > 64 bit debug build of the fedora kernel (which should be worse > case for WARN_ONs etc). > > text dat

Re: Print taint info in more places.

2007-12-13 Thread Adrian Bunk
On Thu, Dec 13, 2007 at 05:49:27PM -0500, Dave Jones wrote: > We've found in the past that various bug reports have had minimal > information, just a few printk's rather than a complete oops, > and it's taken several round-trips with the bug reporter before > we've discovered they had some propriet

Re: Print taint info in more places.

2007-12-13 Thread Dave Jones
On Fri, Dec 14, 2007 at 12:08:46AM +0100, Andi Kleen wrote: > Dave Jones <[EMAIL PROTECTED]> writes: > > > #define WARN_ON(condition) ({ > > \ > >int __ret_warn_on = !!(condition); \ > >if (unlikely(__ret_warn

Re: Print taint info in more places.

2007-12-13 Thread Mauricio Mauad Menegaz Filho
2007/12/13, Andi Kleen <[EMAIL PROTECTED]>: > Dave Jones <[EMAIL PROTECTED]> writes: > > > #define WARN_ON(condition) ({ > > \ > > int __ret_warn_on = !!(condition); \ > > if (unlikely(__ret_warn_on)) {

Re: Print taint info in more places.

2007-12-13 Thread Andi Kleen
Dave Jones <[EMAIL PROTECTED]> writes: > #define WARN_ON(condition) ({ > \ > int __ret_warn_on = !!(condition); \ > if (unlikely(__ret_warn_on)) { \ > - printk("WA