Re: Patch for inconsistent recording of block device statistics

2005-03-23 Thread Jens Axboe
On Thu, Mar 24 2005, Mark Goodwin wrote: > > On Wed, 23 Mar 2005, Jens Axboe wrote: > > Yes, I will make sure it gets committed. Thanks for your help so far. > > > > -- > > Jens Axboe > > Jens, > > SGI needs this fix. Will it find it's way into SLES9/SP2? > Or should we open a SuSE bug? A li

Re: Patch for inconsistent recording of block device statistics

2005-03-23 Thread Mark Goodwin
On Wed, 23 Mar 2005, Jens Axboe wrote: > Yes, I will make sure it gets committed. Thanks for your help so far. > > -- > Jens Axboe Jens, SGI needs this fix. Will it find it's way into SLES9/SP2? Or should we open a SuSE bug? Thanks -- Mark Goodwin - To unsubscribe from this list: send the li

Re: Patch for inconsistent recording of block device statistics

2005-03-23 Thread Jens Axboe
On Wed, Mar 23 2005, Mark Seger wrote: > > >>re: your patch - I did try it on both an Operton and Xeon box. It > >>worked find on the Opeteron and reported 0 for all the sectors on the > >>Xeon. If nothing immediately jumps to your mind could it have been > >>something I did wrong? I'll try

Re: Patch for inconsistent recording of block device statistics

2005-03-23 Thread Mark Seger
re: your patch - I did try it on both an Operton and Xeon box. It worked find on the Opeteron and reported 0 for all the sectors on the Xeon. If nothing immediately jumps to your mind could it have been something I did wrong? I'll try another build after I send this along, but I don't see h

Re: Patch for inconsistent recording of block device statistics

2005-03-23 Thread Jens Axboe
On Wed, Mar 23 2005, Mark Seger wrote: > > >I don't like this patch, it adds 4 * sizeof(unsigned long) to struct > >request when it can be solved without adding anything. The idea is > >sound, though, the current way the stats are done isn't very > >interesting. > > > > > Actually I wasn't all th

Re: Patch for inconsistent recording of block device statistics

2005-03-23 Thread Mark Seger
I don't like this patch, it adds 4 * sizeof(unsigned long) to struct request when it can be solved without adding anything. The idea is sound, though, the current way the stats are done isn't very interesting. Actually I wasn't all that excited about using the extra variable myself. However,

Re: Patch for inconsistent recording of block device statistics

2005-03-23 Thread Jens Axboe
On Tue, Mar 22 2005, Mark Seger wrote: > The read/write statistics for both sectors and merges are calculated at > the time requests first enter the request queue but the remainder of the > statistics, such as the number of read/writes are calculated at the time > the I/O completes. As a result