Re: Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user

2007-05-16 Thread Satyam Sharma
On 5/16/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > 2. It has a useless parameter specifying the kmap slot. >The functions above default to KM_USER0 which is also always used when >zero_user_page was called except in one single case. We open code that >single case to draw attenti

Re: Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user

2007-05-15 Thread Nick Piggin
Christoph Lameter wrote: On Wed, 16 May 2007, Nick Piggin wrote: Well sure, if that's all Christoph is worried about, then it isn't really valid because in generic code we have to follow the architecture abstraction API -- there is no "non highmem platform" in generic code :) But there is a

Re: Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user

2007-05-15 Thread Christoph Lameter
On Wed, 16 May 2007, Nick Piggin wrote: > Well sure, if that's all Christoph is worried about, then it isn't > really valid because in generic code we have to follow the architecture > abstraction API -- there is no "non highmem platform" in generic code :) But there is a default KM_USER0 that is

Re: Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user

2007-05-15 Thread Nick Piggin
Andrew Morton wrote: On Wed, 16 May 2007 14:52:05 +1000 Nick Piggin <[EMAIL PROTECTED]> wrote: On the other hand non highmem platforms are burdened with always repeating the same KM_USER0 in every function call. Isnt it enough to know that standard functions use KM_USER0 for their operations?

Re: Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user

2007-05-15 Thread Andrew Morton
On Wed, 16 May 2007 14:52:05 +1000 Nick Piggin <[EMAIL PROTECTED]> wrote: > Christoph Lameter wrote: > > On Tue, 15 May 2007, Andrew Morton wrote: > > > > > >>> The functions above default to KM_USER0 which is also always used when > >>> zero_user_page was called except in one single case. W

Re: Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user

2007-05-15 Thread Nick Piggin
Christoph Lameter wrote: On Tue, 15 May 2007, Andrew Morton wrote: The functions above default to KM_USER0 which is also always used when zero_user_page was called except in one single case. We open code that single case to draw attention to the spot. Dunno. fwiw, we decided to _not_

Re: Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user

2007-05-15 Thread Christoph Lameter
On Tue, 15 May 2007, Andrew Morton wrote: > >The functions above default to KM_USER0 which is also always used when > >zero_user_page was called except in one single case. We open code that > >single case to draw attention to the spot. > > > > Dunno. fwiw, we decided to _not_ embed

Re: Pagecache zeroing: zero_user_segment, zero_user_segments and zero_user

2007-05-15 Thread Andrew Morton
On Tue, 15 May 2007 20:00:18 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > Simplify page cache zeroing of segments of pages through 3 functions > > > zero_user_segments(page, start1, end1, start2, end2) > > Zeros two segments of the page. It takes the position where to >