Re: Page migration issue with UBIFS

2016-03-21 Thread Richard Weinberger
Am 22.03.2016 um 00:00 schrieb Andrew Morton: > On Wed, 16 Mar 2016 21:47:20 +0100 Richard Weinberger wrote: > >> Adding more CC's. >> >> Am 16.03.2016 um 15:27 schrieb Kirill A. Shutemov: >>> On Wed, Mar 16, 2016 at 05:21:56PM +0300, Kirill A. Shutemov wrote: On Wed, Mar 16, 2016 at 12:18:5

Re: Page migration issue with UBIFS

2016-03-21 Thread Andrew Morton
On Wed, 16 Mar 2016 21:47:20 +0100 Richard Weinberger wrote: > Adding more CC's. > > Am 16.03.2016 um 15:27 schrieb Kirill A. Shutemov: > > On Wed, Mar 16, 2016 at 05:21:56PM +0300, Kirill A. Shutemov wrote: > >> On Wed, Mar 16, 2016 at 12:18:50AM +0100, Richard Weinberger wrote: > >>> Am 15.03.

Re: Page migration issue with UBIFS

2016-03-21 Thread Christoph Hellwig
On Wed, Mar 16, 2016 at 05:21:56PM +0300, Kirill A. Shutemov wrote: > > FYI, with a dummy ->migratepage() which returns only -EINVAL UBIFS does no > > longer explode upon page migration. > > Tomorrow I'll do more tests to make sure. > > Could you check if something like this would fix the issue. >

Re: Page migration issue with UBIFS

2016-03-19 Thread Boris Brezillon
Hi, On Tue, 15 Mar 2016 15:16:11 +0100 Richard Weinberger wrote: > Hi! > > We're facing this issue from 2014 on UBIFS: > http://www.spinics.net/lists/linux-fsdevel/msg79941.html Just to let you know I was able to reproduce the exact same bug on a sama5d3 with UBIFS + CMA enabled (CMA allocatio

Re: Page migration issue with UBIFS

2016-03-19 Thread Joonsoo Kim
On Wed, Mar 16, 2016 at 09:47:20PM +0100, Richard Weinberger wrote: > Adding more CC's. > > Am 16.03.2016 um 15:27 schrieb Kirill A. Shutemov: > > On Wed, Mar 16, 2016 at 05:21:56PM +0300, Kirill A. Shutemov wrote: > >> On Wed, Mar 16, 2016 at 12:18:50AM +0100, Richard Weinberger wrote: > >>> Am 1

Re: Page migration issue with UBIFS

2016-03-19 Thread Richard Weinberger
Am 17.03.2016 um 08:11 schrieb Joonsoo Kim: >> It is still not clear why UBIFS has to provide a >migratepage() and what the >> expected semantics >> are. >> What we know so far is that the fall back migration function is broken. I'm >> sure not only on UBIFS. >> >> Can CMA folks please clarify? :

Re: Page migration issue with UBIFS

2016-03-19 Thread Kirill A. Shutemov
On Wed, Mar 16, 2016 at 05:21:56PM +0300, Kirill A. Shutemov wrote: > On Wed, Mar 16, 2016 at 12:18:50AM +0100, Richard Weinberger wrote: > > Am 15.03.2016 um 16:37 schrieb Christoph Hellwig: > > > On Tue, Mar 15, 2016 at 04:32:40PM +0100, Richard Weinberger wrote: > > >>> Or if ->page_mkwrite() wa

Re: Page migration issue with UBIFS

2016-03-19 Thread Richard Weinberger
Adding more CC's. Am 16.03.2016 um 15:27 schrieb Kirill A. Shutemov: > On Wed, Mar 16, 2016 at 05:21:56PM +0300, Kirill A. Shutemov wrote: >> On Wed, Mar 16, 2016 at 12:18:50AM +0100, Richard Weinberger wrote: >>> Am 15.03.2016 um 16:37 schrieb Christoph Hellwig: On Tue, Mar 15, 2016 at 04:32

Re: Page migration issue with UBIFS

2016-03-19 Thread Kirill A. Shutemov
On Wed, Mar 16, 2016 at 12:18:50AM +0100, Richard Weinberger wrote: > Am 15.03.2016 um 16:37 schrieb Christoph Hellwig: > > On Tue, Mar 15, 2016 at 04:32:40PM +0100, Richard Weinberger wrote: > >>> Or if ->page_mkwrite() was called, why the page is not dirty? > >> > >> BTW: UBIFS does not implement

Re: Page migration issue with UBIFS

2016-03-18 Thread Joonsoo Kim
2016-03-17 17:13 GMT+09:00 Richard Weinberger : > Am 17.03.2016 um 08:11 schrieb Joonsoo Kim: >>> It is still not clear why UBIFS has to provide a >migratepage() and what >>> the expected semantics >>> are. >>> What we know so far is that the fall back migration function is broken. I'm >>> sure n

Re: Page migration issue with UBIFS

2016-03-15 Thread Richard Weinberger
Am 15.03.2016 um 16:37 schrieb Christoph Hellwig: > On Tue, Mar 15, 2016 at 04:32:40PM +0100, Richard Weinberger wrote: >>> Or if ->page_mkwrite() was called, why the page is not dirty? >> >> BTW: UBIFS does not implement ->migratepage(), could this be a problem? > > This might be the reason. I c

Re: Page migration issue with UBIFS

2016-03-15 Thread Richard Weinberger
Christoph, Am 15.03.2016 um 16:37 schrieb Christoph Hellwig: > On Tue, Mar 15, 2016 at 04:32:40PM +0100, Richard Weinberger wrote: >>> Or if ->page_mkwrite() was called, why the page is not dirty? >> >> BTW: UBIFS does not implement ->migratepage(), could this be a problem? > > This might be the

Re: Page migration issue with UBIFS

2016-03-15 Thread Kirill A. Shutemov
On Tue, Mar 15, 2016 at 04:25:50PM +0100, Richard Weinberger wrote: > Kirill, > > Am 15.03.2016 um 16:17 schrieb Kirill A. Shutemov: > > On Tue, Mar 15, 2016 at 03:16:11PM +0100, Richard Weinberger wrote: > >> Hi! > >> > >> We're facing this issue from 2014 on UBIFS: > >> http://www.spinics.net/li

Re: Page migration issue with UBIFS

2016-03-15 Thread Christoph Hellwig
On Tue, Mar 15, 2016 at 04:32:40PM +0100, Richard Weinberger wrote: > > Or if ->page_mkwrite() was called, why the page is not dirty? > > BTW: UBIFS does not implement ->migratepage(), could this be a problem? This might be the reason. I can't reall make sense of buffer_migrate_page, but it seem

Re: Page migration issue with UBIFS

2016-03-15 Thread Christoph Hellwig
On Tue, Mar 15, 2016 at 04:25:50PM +0100, Richard Weinberger wrote: > Thanks for your quick response! > > I also don't think that the root cause is CMA or migration but it seems > to be the messenger. > > Can you confirm that UBIFS's assumptions are valid? > I'm trying to rule out possible issues

Re: Page migration issue with UBIFS

2016-03-15 Thread Richard Weinberger
Am 15.03.2016 um 16:17 schrieb Kirill A. Shutemov: > On Tue, Mar 15, 2016 at 03:16:11PM +0100, Richard Weinberger wrote: >> Hi! >> >> We're facing this issue from 2014 on UBIFS: >> http://www.spinics.net/lists/linux-fsdevel/msg79941.html >> >> So sum up: >> UBIFS does not allow pages directly marke

Re: Page migration issue with UBIFS

2016-03-15 Thread Richard Weinberger
Kirill, Am 15.03.2016 um 16:17 schrieb Kirill A. Shutemov: > On Tue, Mar 15, 2016 at 03:16:11PM +0100, Richard Weinberger wrote: >> Hi! >> >> We're facing this issue from 2014 on UBIFS: >> http://www.spinics.net/lists/linux-fsdevel/msg79941.html >> >> So sum up: >> UBIFS does not allow pages direc

Re: Page migration issue with UBIFS

2016-03-15 Thread Kirill A. Shutemov
On Tue, Mar 15, 2016 at 03:16:11PM +0100, Richard Weinberger wrote: > Hi! > > We're facing this issue from 2014 on UBIFS: > http://www.spinics.net/lists/linux-fsdevel/msg79941.html > > So sum up: > UBIFS does not allow pages directly marked as dirty. It want's everyone to do > it via UBIFS's > -