Re: PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios

2007-03-02 Thread Sam Hopkins
> Well, given that bi_end_io() is called after the "io" has completed, I'm > assuming that networking has completely finished with the memory by the > time bi_end_io() gets called. > > I guess one can envisage situations where that might not happen, but they'd > be terribly buggy ones, surely. Th

Re: PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios

2007-03-01 Thread Christoph Hellwig
On Thu, Mar 01, 2007 at 09:09:42PM -0800, Andrew Morton wrote: > > or document that drivers need to handle it specially and give them a > > way to find out about them. (Or do the horrible slab refcounting hack > > I wrote up above) > > OK. So you're proposing that XFS and ext3 simply stop sing sl

Re: PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios

2007-03-01 Thread Andrew Morton
On Fri, 2 Mar 2007 05:03:51 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Thu, Mar 01, 2007 at 09:00:44PM -0800, Andrew Morton wrote: > > I that case we're talking about different things. > > > > I thought the proposal was to continue to use slab pages, but to take a ref > > on them as

Re: PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios

2007-03-01 Thread Christoph Hellwig
On Thu, Mar 01, 2007 at 09:00:44PM -0800, Andrew Morton wrote: > I that case we're talking about different things. > > I thought the proposal was to continue to use slab pages, but to take a ref > on them as they're added to the bio, drop that ref in bi_end_io()? That would give you silent memory

Re: PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios

2007-03-01 Thread Andrew Morton
On Fri, 2 Mar 2007 04:49:10 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Thu, Mar 01, 2007 at 08:48:06PM -0800, Andrew Morton wrote: > > On Fri, 2 Mar 2007 04:30:39 + Christoph Hellwig <[EMAIL PROTECTED]> > > wrote: > > > > > But in this case we'd really need to enforce this, and

Re: PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios

2007-03-01 Thread Christoph Hellwig
On Thu, Mar 01, 2007 at 08:48:06PM -0800, Andrew Morton wrote: > On Fri, 2 Mar 2007 04:30:39 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > But in this case we'd really need to enforce this, and add a > > BUG_ON(PageSlab(page)) in bio_add_page to trip everyone submit > > this kind of pag

Re: PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios

2007-03-01 Thread Andrew Morton
On Fri, 2 Mar 2007 04:30:39 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > But in this case we'd really need to enforce this, and add a > BUG_ON(PageSlab(page)) in bio_add_page to trip everyone submit > this kind of pages. That would be BUG_ON(PageSlab(page) && page_count(page) ==

Re: PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios

2007-03-01 Thread Christoph Hellwig
On Thu, Mar 01, 2007 at 07:22:45PM -0800, Andrew Morton wrote: > Well I spose slab _could_ take a ref on these pages. What it would need to do is: - add a reference for every object touching this page - don't give the page back to the page allocator or reuse any single object inside it until

Re: PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios

2007-03-01 Thread Andrew Morton
On Fri, 2 Mar 2007 02:29:19 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Thu, Mar 01, 2007 at 05:42:04PM -0800, Andrew Morton wrote: > > Something funny is going on here. > > Not so funny for those who've tried to sort out the issue over > the past years and just got ignored.. > > > G

Re: PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios

2007-03-01 Thread Christoph Hellwig
On Thu, Mar 01, 2007 at 05:42:04PM -0800, Andrew Morton wrote: > Something funny is going on here. Not so funny for those who've tried to sort out the issue over the past years and just got ignored.. > Generally, one should increment the refcount of a page when it is put into > some container. T

Re: PATCH 2.6.21-rc1 aoe: handle zero _count pages in bios

2007-03-01 Thread Andrew Morton
On Thu, 1 Mar 2007 18:15:10 -0500 "Ed L. Cashin" <[EMAIL PROTECTED]> wrote: > This patch works around a problem discussed here and on the XFS > mailing list in January. > > http://lkml.org/lkml/2007/1/19/56 > > To summarize the issue: If XFS (or any other creator of bios) gives > the aoe drive