Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-13 Thread David Miller
From: Eric Dumazet Date: Thu, 06 Jun 2013 20:59:48 -0700 > On Thu, 2013-06-06 at 23:06 -0400, Steven Rostedt wrote: >> On Fri, Jun 07, 2013 at 12:16:56AM +0200, Steinar H. Gunderson wrote: >> > Hi, >> > >> > In 3.10.0-rc4, I get this on boot: >> > >> > [ 16.871043] BUG: unable to handle kerne

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Eric Dumazet
On Fri, 2013-06-07 at 20:46 +0200, Steinar H. Gunderson wrote: > On Fri, Jun 07, 2013 at 02:44:19PM -0400, Steven Rostedt wrote: > > Do know if you have CONFIG_NET_NS set in your .config? > > Sorry, I forgot to answer this: No, it is not set. OK please try the following patch, Steven forgot to up

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Steinar H. Gunderson
On Fri, Jun 07, 2013 at 02:44:19PM -0400, Steven Rostedt wrote: > Do know if you have CONFIG_NET_NS set in your .config? Sorry, I forgot to answer this: No, it is not set. /* Steinar */ -- Homepage: http://www.sesse.net/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Steven Rostedt
On Fri, 2013-06-07 at 20:34 +0200, Steinar H. Gunderson wrote: > On Fri, Jun 07, 2013 at 02:26:08PM -0400, Steven Rostedt wrote: > > On Fri, 2013-06-07 at 19:52 +0200, Steinar H. Gunderson wrote: > > Ah, that's because of this: module_init(ipgre_init); Where it makes it > > into: > > > >

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Steinar H. Gunderson
On Fri, Jun 07, 2013 at 02:26:08PM -0400, Steven Rostedt wrote: > On Fri, 2013-06-07 at 19:52 +0200, Steinar H. Gunderson wrote: > Ah, that's because of this: module_init(ipgre_init); Where it makes it > into: > > : >0: 55 push %ebp >1: 89 e5

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Steven Rostedt
On Fri, 2013-06-07 at 19:52 +0200, Steinar H. Gunderson wrote: > On Fri, Jun 07, 2013 at 12:12:23PM -0400, Steven Rostedt wrote: > >> Ffffa0e76000 u ip_tunnel_init_net [ip_gre] > > What do you get if you do an objdump -Dr ip_gre.ko > > > > And then look for ipgre_init, and then subtract 0xb0

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Steinar H. Gunderson
On Fri, Jun 07, 2013 at 12:12:23PM -0400, Steven Rostedt wrote: >> Ffffa0e76000 u ip_tunnel_init_net [ip_gre] > What do you get if you do an objdump -Dr ip_gre.ko > > And then look for ipgre_init, and then subtract 0xb053 (45139) from its > address. As that is: a0e81055 - a0e

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Steven Rostedt
On Fri, 2013-06-07 at 17:46 +0200, Steinar H. Gunderson wrote: > On Fri, Jun 07, 2013 at 11:15:00AM -0400, Steven Rostedt wrote: > > net: Remove __net_init/exit from exported functions > > > > If CONFIG_NET_NS is not set then __net_init is the same as __init and > > __net_exit is the same as __exi

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Steinar H. Gunderson
On Fri, Jun 07, 2013 at 11:15:00AM -0400, Steven Rostedt wrote: > net: Remove __net_init/exit from exported functions > > If CONFIG_NET_NS is not set then __net_init is the same as __init and > __net_exit is the same as __exit. These functions will be removed from > memory after the module loads o

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Steven Rostedt
On Fri, 2013-06-07 at 06:40 -0700, Eric Dumazet wrote: > On Fri, 2013-06-07 at 10:54 +0200, Steinar H. Gunderson wrote: > > On Thu, Jun 06, 2013 at 11:06:48PM -0400, Steven Rostedt wrote: > > > Note the faulting address is 0xa0e52001, which is around the > > > above address, be interesting

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Eric Dumazet
On Fri, 2013-06-07 at 10:54 +0200, Steinar H. Gunderson wrote: > On Thu, Jun 06, 2013 at 11:06:48PM -0400, Steven Rostedt wrote: > > Note the faulting address is 0xa0e52001, which is around the > > above address, be interesting to know what was at that location. > > Doh, I looked at the wr

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Steinar H. Gunderson
On Thu, Jun 06, 2013 at 11:06:48PM -0400, Steven Rostedt wrote: > Note the faulting address is 0xa0e52001, which is around the > above address, be interesting to know what was at that location. Doh, I looked at the wrong place in kallsyms: a0e52000 u ip_tunnel_init_net [ip_gre]

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Steinar H. Gunderson
On Thu, Jun 06, 2013 at 11:06:48PM -0400, Steven Rostedt wrote: > Note the faulting address is 0xa0e52001, which is around the > above address, be interesting to know what was at that location. Aha, the plot thickens: root 6095 0.0 0.0 6632 596 ?DJun06 0:00 /sbin/

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Steinar H. Gunderson
On Thu, Jun 06, 2013 at 08:59:48PM -0700, Eric Dumazet wrote: > Steinar, please make sure you recompiled your modules, because this > looks like you loaded old modules. I compiled the kernel using make-kpkg, so I don't see how that would happen. Also, the timestamps indicate everything is fine: -

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-07 Thread Steinar H. Gunderson
On Thu, Jun 06, 2013 at 11:06:48PM -0400, Steven Rostedt wrote: > Note the faulting address is 0xa0e52001, which is around the > above address, be interesting to know what was at that location. Is there any way I can figure this out? The machine in question is still running. kallsyms doesn

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-06 Thread Eric Dumazet
On Thu, 2013-06-06 at 23:06 -0400, Steven Rostedt wrote: > On Fri, Jun 07, 2013 at 12:16:56AM +0200, Steinar H. Gunderson wrote: > > Hi, > > > > In 3.10.0-rc4, I get this on boot: > > > > [ 16.871043] BUG: unable to handle kernel NULL pointer dereference at > > 0003 > > [ 16.8794

Re: NULL pointer dereference when loading the gre module (3.10.0-rc4)

2013-06-06 Thread Steven Rostedt
On Fri, Jun 07, 2013 at 12:16:56AM +0200, Steinar H. Gunderson wrote: > Hi, > > In 3.10.0-rc4, I get this on boot: > > [ 16.871043] BUG: unable to handle kernel NULL pointer dereference at > 0003 > [ 16.879453] IP: [] 0xa0e52001 Strange, kallsyms should have registered t