Re: MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show()

2016-10-24 Thread Theodore Ts'o
On Mon, Oct 24, 2016 at 04:53:32PM +0200, SF Markus Elfring wrote: > >>> since reading from /proc isn't done in a tight loop, and even if it were, > >>> the use of vsprintf is the tiniest part of the overhead. > >> > >> Thanks for your software development opinion. > > > > It's a lot more than jus

Re: MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show()

2016-10-24 Thread SF Markus Elfring
>> I am curious if a second approach will become acceptable in the near future. > > I don't know what you were asking. I am trying to clarify the suggested software evolution again. > I was merely point out that the wording was factually incorrect > in all of the patches, Thanks for this infor

Re: MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show()

2016-10-24 Thread Theodore Ts'o
On Mon, Oct 24, 2016 at 04:02:49PM +0200, SF Markus Elfring wrote: > > You should fix this in all the patches. > I am curious if a second approach will become acceptable in the near > future. I don't know what you were asking. I was merely point out that the > wording was factually incorrect in a

Re: MIPS/kernel/r2-to-r6-emul: Use seq_puts() in mipsr2_stats_show()

2016-10-24 Thread SF Markus Elfring
>> A string which did not contain a data format specification should be put >> into a sequence. > > This is not a correct description of what you are doing. A better > description would be to say: > > "Use seq_put[sc]() instead of seq_printf() since the string does not > contain a data format sp