Re: Linux 2.6.25-rc2

2008-02-19 Thread Pekka Enberg
On 2/20/2008, "Zhang, Yanmin" <[EMAIL PROTECTED]> wrote: > Kernel with the reverting patch is ok. > I ran reboot/hackbench for more than 10 times on every one of my 3 x86-64 > machines, and kernel didn't crash. Great, Linus reverted the patch yesterday. Thanks for testing! -- To unsubscribe from

Re: Linux 2.6.25-rc2

2008-02-19 Thread Zhang, Yanmin
On Wed, 2008-02-20 at 10:08 +0800, Zhang, Yanmin wrote: > On Wed, 2008-02-20 at 08:36 +0800, Zhang, Yanmin wrote: > > On Tue, 2008-02-19 at 17:52 +0200, Pekka Enberg wrote: > > > Ingo Molnar wrote: > > > > * Pekka Enberg <[EMAIL PROTECTED]> wrote: > > > > > > > >>> Yes, this can happen. Are you sa

Re: Linux 2.6.25-rc2

2008-02-19 Thread Zhang, Yanmin
On Wed, 2008-02-20 at 08:36 +0800, Zhang, Yanmin wrote: > On Tue, 2008-02-19 at 17:52 +0200, Pekka Enberg wrote: > > Ingo Molnar wrote: > > > * Pekka Enberg <[EMAIL PROTECTED]> wrote: > > > > > >>> Yes, this can happen. Are you saying it is not safe to be in the > > >>> lockless path when an IRQ

Re: Linux 2.6.25-rc2

2008-02-19 Thread Zhang, Yanmin
On Tue, 2008-02-19 at 17:52 +0200, Pekka Enberg wrote: > Ingo Molnar wrote: > > * Pekka Enberg <[EMAIL PROTECTED]> wrote: > > > >>> Yes, this can happen. Are you saying it is not safe to be in the > >>> lockless path when an IRQ triggers? > >> Hmm. The barrier() in slab_free() looks fishy. The co

Re: Linux 2.6.25-rc2

2008-02-19 Thread Mathieu Desnoyers
* Pekka Enberg ([EMAIL PROTECTED]) wrote: > Hi Mathieu, > > On Feb 19, 2008 4:02 PM, Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > > - stat(c, ALLOC_FASTPATH); seems to be using a var++, therefore > > indicating it is not reentrant if IRQs are disabled. Since those are > > only stats, I guess

Re: Linux 2.6.25-rc2

2008-02-19 Thread Mathieu Desnoyers
* Eric Dumazet ([EMAIL PROTECTED]) wrote: > On Tue, 19 Feb 2008 09:02:30 -0500 > Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > > > * Pekka Enberg ([EMAIL PROTECTED]) wrote: > > > On Feb 19, 2008 8:54 AM, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > > > > > > [ 5282.056415] [ cut here ]

Re: Linux 2.6.25-rc2

2008-02-19 Thread Torsten Kaiser
On Feb 19, 2008 5:20 PM, Linus Torvalds <[EMAIL PROTECTED]> wrote: > So: > - it might be something else entirely > - it might still be the local cmpxchg, just Torsten didn't happen to >notice it until later. My new hackbench-testcase also killed 2.6.24-rc2-mm1, so I really noticed to late.

Re: Linux 2.6.25-rc2

2008-02-19 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > Earlier today i turned off local-cmpxchg and havent had a crash or > hang since then - but at 200 bootups and 4-5 crashes in a week that's > not conclusive yet. I think others might have workloads that trigger > this bug more often. i mean, today i'v

Re: Linux 2.6.25-rc2

2008-02-19 Thread Ingo Molnar
* Linus Torvalds <[EMAIL PROTECTED]> wrote: > So: > - it might be something else entirely > - it might still be the local cmpxchg, just Torsten didn't happen to >notice it until later. > - it might still be the local cmpxchg, but something else changed its >patterns to actually make

Re: Linux 2.6.25-rc2

2008-02-19 Thread Linus Torvalds
On Tue, 19 Feb 2008, Eric Dumazet wrote: > > cmpxchg_local(&c->freelist, object, object[c->offset]) can succeed, > while an interrupt came (on this cpu), and several allocations were done, > and one free was performed at the end of this interruption, so 'object' > was recycled. I think you may

Re: Linux 2.6.25-rc2

2008-02-19 Thread Eric Dumazet
On Tue, 19 Feb 2008 09:02:30 -0500 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > * Pekka Enberg ([EMAIL PROTECTED]) wrote: > > On Feb 19, 2008 8:54 AM, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > > > > > [ 5282.056415] [ cut here ] > > > > > [ 5282.059757] kernel BUG at li

Re: Linux 2.6.25-rc2

2008-02-19 Thread Linus Torvalds
On Tue, 19 Feb 2008, Pekka Enberg wrote: > > Hmm. The barrier() in slab_free() looks fishy. The comment says it's > there to make sure we've retrieved c->freelist before c->page but then > it uses a _compiler barrier_ which doesn't affect the CPU and the > reads may still be re-ordered... Not su

Re: Linux 2.6.25-rc2

2008-02-19 Thread Pekka Enberg
Ingo Molnar wrote: * Ingo Molnar <[EMAIL PROTECTED]> wrote: If this (or my other patch) indeed solves the problem i'd still favor a full revert of the SLUB_FASTPATH (commit 1f84260c8ce3b1ce26d4), it looks quite un-cooked and quite un-tested for multiple independent reasons. Sigh, why do i a

Re: Linux 2.6.25-rc2

2008-02-19 Thread Pekka Enberg
Ingo Molnar wrote: * Pekka Enberg <[EMAIL PROTECTED]> wrote: Yes, this can happen. Are you saying it is not safe to be in the lockless path when an IRQ triggers? Hmm. The barrier() in slab_free() looks fishy. The comment says it's there to make sure we've retrieved c->freelist before c->page b

Re: Linux 2.6.25-rc2

2008-02-19 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > If this (or my other patch) indeed solves the problem i'd still favor > a full revert of the SLUB_FASTPATH (commit 1f84260c8ce3b1ce26d4), it > looks quite un-cooked and quite un-tested for multiple independent > reasons. > > Sigh, why do i again have

Re: Linux 2.6.25-rc2

2008-02-19 Thread Ingo Molnar
* Pekka Enberg <[EMAIL PROTECTED]> wrote: > > Yes, this can happen. Are you saying it is not safe to be in the > > lockless path when an IRQ triggers? > > Hmm. The barrier() in slab_free() looks fishy. The comment says it's > there to make sure we've retrieved c->freelist before c->page but th

Re: Linux 2.6.25-rc2

2008-02-19 Thread Pekka Enberg
Hi Mathieu, On Feb 19, 2008 4:02 PM, Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > > Since this shows mostly with network card drivers, I think the most > > plausible cause would be an IRQ nesting over kmem_cache_alloc_node and > > calling it. On Feb 19, 2008 4:21 PM, Pekka Enberg <[EMAIL PROTEC

Re: Linux 2.6.25-rc2

2008-02-19 Thread Pekka Enberg
Hi Mathieu, On Feb 19, 2008 4:02 PM, Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > - stat(c, ALLOC_FASTPATH); seems to be using a var++, therefore > indicating it is not reentrant if IRQs are disabled. Since those are > only stats, I guess it's ok, but still weird. What is not re-entrant? O

Re: Linux 2.6.25-rc2

2008-02-19 Thread Mathieu Desnoyers
* Pekka Enberg ([EMAIL PROTECTED]) wrote: > On Feb 19, 2008 8:54 AM, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > > > > [ 5282.056415] [ cut here ] > > > > [ 5282.059757] kernel BUG at lib/list_debug.c:33! > > > > [ 5282.062055] invalid opcode: [1] SMP > > > > [ 5282.062

Re: Linux 2.6.25-rc2

2008-02-19 Thread Ingo Molnar
* Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > Ingo, a comment in slub.c explains it : > > /* > * The SLUB_FASTPATH path is provisional and is currently disabled if the > * kernel is compiled with preemption or if the arch does not support > * fast cmpxchg operations. There are a couple of

Re: Linux 2.6.25-rc2

2008-02-19 Thread Mathieu Desnoyers
* Ingo Molnar ([EMAIL PROTECTED]) wrote: > > * Pekka Enberg <[EMAIL PROTECTED]> wrote: > > > Mathieu, Christoph is on vacation and I'm not at all that familiar > > with this cmpxchg_local() optimization, so if you could take a peek at > > this bug report to see if you can spot something obvious

Re: Linux 2.6.25-rc2

2008-02-19 Thread Pekka Enberg
Hi, Pekka Enberg <[EMAIL PROTECTED]> wrote: > > Mathieu, Christoph is on vacation and I'm not at all that familiar > > with this cmpxchg_local() optimization, so if you could take a peek at > > this bug report to see if you can spot something obviously wrong with > > it, I would much appreciate th

Re: Linux 2.6.25-rc2

2008-02-19 Thread Ingo Molnar
* Pekka Enberg <[EMAIL PROTECTED]> wrote: > Mathieu, Christoph is on vacation and I'm not at all that familiar > with this cmpxchg_local() optimization, so if you could take a peek at > this bug report to see if you can spot something obviously wrong with > it, I would much appreciate that. h

Re: Linux 2.6.25-rc2 regression: LVM cannot find volume group

2008-02-19 Thread Tilman Schmidt
[added CCs from the other thread on this topic] Alasdair G Kergon schrieb: On Sat, Feb 16, 2008 at 11:37:37PM +0100, Jiri Slaby wrote: # CONFIG_SYSFS_DEPRECATED is not set IMHO That should be *set* by default until everyone has had time to update their userspace software to cope with the chan

Re: Linux 2.6.25-rc2

2008-02-18 Thread Pekka Enberg
On Feb 19, 2008 8:54 AM, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > > > [ 5282.056415] [ cut here ] > > > [ 5282.059757] kernel BUG at lib/list_debug.c:33! > > > [ 5282.062055] invalid opcode: [1] SMP > > > [ 5282.062055] CPU 3 > > > > hm. Your crashes do seem to span

Re: Linux 2.6.25-rc2

2008-02-18 Thread Torsten Kaiser
On Feb 19, 2008 7:11 AM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > * Torsten Kaiser <[EMAIL PROTECTED]> wrote: > > On Feb 15, 2008 10:23 PM, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > > > > Ok, > > > this kernel is a winner. > > > > Sadly not for me: > > [ 5282.056415] [ cut here ]

Re: Linux 2.6.25-rc2

2008-02-18 Thread Torsten Kaiser
On Feb 19, 2008 12:54 AM, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Sat, 16 Feb 2008, Torsten Kaiser wrote: > > > > [ 5282.056415] [ cut here ] > > [ 5282.059757] kernel BUG at lib/list_debug.c:33! > > Is there any chance that you could try to bisect this, if it's r

Re: Linux 2.6.25-rc2

2008-02-18 Thread Ingo Molnar
* Torsten Kaiser <[EMAIL PROTECTED]> wrote: > On Feb 15, 2008 10:23 PM, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > > Ok, > > this kernel is a winner. > > Sadly not for me: > [ 5282.056415] [ cut here ] > [ 5282.059757] kernel BUG at lib/list_debug.c:33! > [ 5282.062

Re: Linux 2.6.25-rc2 regression: LVM cannot find volume group

2008-02-18 Thread Alasdair G Kergon
On Sat, Feb 16, 2008 at 11:37:37PM +0100, Jiri Slaby wrote: > # CONFIG_SYSFS_DEPRECATED is not set IMHO That should be *set* by default until everyone has had time to update their userspace software to cope with the changed sysfs layout. Alasdair -- [EMAIL PROTECTED] -- To unsubscribe from this

Re: Linux 2.6.25-rc2

2008-02-18 Thread Linus Torvalds
On Sat, 16 Feb 2008, Torsten Kaiser wrote: > > [ 5282.056415] [ cut here ] > [ 5282.059757] kernel BUG at lib/list_debug.c:33! Is there any chance that you could try to bisect this, if it's repeatable enough for you? Even if you can't bisect it *all* the way, it would be

Re: Linux 2.6.25-rc2 regression: LVM cannot find volume group

2008-02-18 Thread Tilman Schmidt
Am 17.02.2008 schrieb Jeff Chua: I faced the same problem, but resolved with ... vgscan vgchange -a y Sorry, I'm not sure what to do with those two commands. Running them once manually doesn't seem to change anything, and my initrd already contains them AFAICS. Also, ensure you set "write_ca

Re: Linux 2.6.25-rc2 regression: LVM cannot find volume group

2008-02-17 Thread Jeff Chua
On Feb 18, 2008 8:57 AM, Tilman Schmidt <[EMAIL PROTECTED]> wrote: > Am 16.02.2008 23:37 schrieb Jiri Slaby: > > On 02/16/2008 09:12 PM, Alan Cox wrote: > > Try to upgrade to at least lvm 2.02.29 (I guess this is the first version > > which > > understands the new sysfs layout). > I'll have to inv

Re: Linux 2.6.25-rc2 regression: LVM cannot find volume group

2008-02-17 Thread Tilman Schmidt
Am 16.02.2008 23:37 schrieb Jiri Slaby: On 02/16/2008 09:12 PM, Alan Cox wrote: On Sat, 16 Feb 2008 20:14:30 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote: 2.6.25-rc2 fails to bring up my openSUSE 10.3 PC because LVM cannot find the volume group containing the root file system. 2.6.25-rc1 has

Re: Linux 2.6.25-rc2

2008-02-17 Thread Torsten Kaiser
On Feb 17, 2008 9:25 PM, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > There's the Bugzilla entry for it at > http://bugzilla.kernel.org/show_bug.cgi?id=9973 Thank you. > Please update it with the current information. Crash for 2.6.25-rc2-mm1 added. That one had a complete stacktrace, but the t

Re: Linux 2.6.25-rc2

2008-02-17 Thread Rafael J. Wysocki
On Saturday, 16 of February 2008, Torsten Kaiser wrote: > On Feb 15, 2008 10:23 PM, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > > Ok, > > this kernel is a winner. > > Sadly not for me: > [ 5282.056415] [ cut here ] > [ 5282.059757] kernel BUG at lib/list_debug.c:33! >

Re: Linux 2.6.25-rc2 regression: LVM cannot find volume group

2008-02-16 Thread Jiri Slaby
On 02/16/2008 09:12 PM, Alan Cox wrote: On Sat, 16 Feb 2008 20:14:30 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote: 2.6.25-rc2 fails to bring up my openSUSE 10.3 PC because LVM cannot find the volume group containing the root file system. 2.6.25-rc1 has the same problem, 2.6.24 works fine. C

Re: Linux 2.6.25-rc2

2008-02-16 Thread Torsten Kaiser
On Feb 15, 2008 10:23 PM, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > Ok, > this kernel is a winner. Sadly not for me: [ 5282.056415] [ cut here ] [ 5282.059757] kernel BUG at lib/list_debug.c:33! [ 5282.062055] invalid opcode: [1] SMP [ 5282.062055] CPU 3 [ 5282.06

Re: Linux 2.6.25-rc2 regression: LVM cannot find volume group

2008-02-16 Thread Alan Cox
On Sat, 16 Feb 2008 20:14:30 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote: > 2.6.25-rc2 fails to bring up my openSUSE 10.3 PC because LVM > cannot find the volume group containing the root file system. > 2.6.25-rc1 has the same problem, 2.6.24 works fine. Compile in SCSI disk support. Modular e

Re: Linux 2.6.25-rc2

2008-02-16 Thread Jan Engelhardt
On Feb 15 2008 13:23, Linus Torvalds wrote: > >Just to show how _much_ of a winner it is, it's been awarded a coveted >"weasel" series name, which should tell you just how good it's going to >be. It's a name revered in Linux kernel history, and as such this brings >back the good old days where

Re: Linux 2.6.25-rc2

2008-02-15 Thread Rafael J. Wysocki
On Friday, 15 of February 2008, Linus Torvalds wrote: > > Ok, > this kernel is a winner. > > Just to show how _much_ of a winner it is, it's been awarded a coveted > "weasel" series name, which should tell you just how good it's going to > be. It's a name revered in Linux kernel history, and a