Re: Juju

2007-01-29 Thread Pete Zaitcev
On Mon, 29 Jan 2007 14:53:28 -0500, Kristian Høgsberg <[EMAIL PROTECTED]> wrote: > >>git://people.freedesktop.org/~krh/linux-2.6 > > > > This seems to have disappeared. Was it moved or dropped? > > No, it's still there, and I just did a git clone on it. How does it fail for > you? Oh neve

Re: Juju

2007-01-29 Thread Kristian Høgsberg
Pete Zaitcev wrote: On Thu, 25 Jan 2007 16:18:35 -0500, Kristian Høgsberg <[EMAIL PROTECTED]> wrote: Indeed, I've just moved to an in-tree development model now. I still think the out-off-tree model is a good way to prototype, get started and reach "critical mass" with your driver. But as I'

Re: Juju

2007-01-28 Thread Pete Zaitcev
On Thu, 25 Jan 2007 16:18:35 -0500, Kristian Høgsberg <[EMAIL PROTECTED]> wrote: > Indeed, I've just moved to an in-tree development model now. I still think > the out-off-tree model is a good way to prototype, get started and reach > "critical mass" with your driver. But as I'm starting to in

Re: Juju

2007-01-26 Thread Kristian Høgsberg
Greg KH wrote: On Thu, Jan 25, 2007 at 03:38:24PM -0800, Pete Zaitcev wrote: On Thu, 25 Jan 2007 16:18:35 -0500, Kristian H??gsberg <[EMAIL PROTECTED]> wrote: I see that ORBs are always allocated with a call (like SKB) and not embedded into drivers (like URBs). It's great, keep it up. Also, n

Re: Juju

2007-01-26 Thread Stefan Richter
Kristian Høgsberg wrote: > Another thing that probably makes my explanation a little confusing is that > there are two types of transactions: FireWire transactions which consists of > a > request followed by a response and are pretty much the smallest interaction > you can have with a remote

Re: Juju

2007-01-26 Thread Stefan Richter
Pete Zaitcev wrote: > On Fri, 26 Jan 2007 03:35:19 +0100, Stefan Richter <[EMAIL PROTECTED]> wrote: >> The target wrote an SBP-2 status block into our memory. The status block >> contains the FireWire bus address of the ORB to which it belongs. [...] > > I see. SRP has a more flexible tag which ca

Re: Juju

2007-01-25 Thread Greg KH
On Thu, Jan 25, 2007 at 03:38:24PM -0800, Pete Zaitcev wrote: > On Thu, 25 Jan 2007 16:18:35 -0500, Kristian H??gsberg <[EMAIL PROTECTED]> > wrote: > > > > I see that ORBs are always allocated with a call (like SKB) and not > > > embedded into drivers (like URBs). It's great, keep it up. Also, >

Re: Juju

2007-01-25 Thread Pete Zaitcev
On Fri, 26 Jan 2007 03:35:19 +0100, Stefan Richter <[EMAIL PROTECTED]> wrote: > The fundamental thing about SBP-2 is that ORBs ( = SCSI command blocks > plus SBP-2 header) and data buffers all reside in the memory of the > initiator (or of a 3rd party on the FireWire bus). I recognize the concept

Re: Juju

2007-01-25 Thread Kristian Høgsberg
Stefan Richter wrote: Pete Zaitcev wrote: On Thu, 25 Jan 2007 16:18:35 -0500, Kristian Høgsberg <[EMAIL PROTECTED]> wrote: ... will do a status write to the status address specified in the ORB, at which point the SBP-2 transaction is complete. You know, I wanted to use this picture for a long

Re: Juju

2007-01-25 Thread Stefan Richter
Pete Zaitcev wrote: > On Thu, 25 Jan 2007 16:18:35 -0500, Kristian Høgsberg <[EMAIL PROTECTED]> > wrote: ... >> will do a status write to the status address specified in the ORB, at which >> point the SBP-2 transaction is complete. > > You know, I wanted to use this picture for a long time: > h

Re: Juju

2007-01-25 Thread Pete Zaitcev
On Thu, 25 Jan 2007 16:18:35 -0500, Kristian Høgsberg <[EMAIL PROTECTED]> wrote: > > I see that ORBs are always allocated with a call (like SKB) and not > > embedded into drivers (like URBs). It's great, keep it up. Also, > > never allow drivers to pass DMA-mapped buffers into fw_send_request > >

Re: Juju

2007-01-25 Thread Kristian Høgsberg
Pete Zaitcev wrote: Hi, Kristian: I only looked briefly at SBP-2, and at submit/callback paths it pulled, because I do not understand most of the other issues. Great, thanks for giving this a look-over, much appreciated. Executive summary: please implement proper ORB cancellation. This is ho

Re: Juju

2007-01-25 Thread Stefan Richter
Pete Zaitcev wrote: ... > Now, about small things: Thanks Pete, I'm sure I will find some of these issues in mainline's sbp2 too. :-) ... > P.S. If I were using git, I would clone a Linus git tree and work > there. All this out-of-tree module stuff is just a waste of time. Kristian just announce