Re: ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

2016-09-27 Thread Paul Bolle
You're in Eliza mode again. (Hat tip to Björn Mork, https://lkml.org/lkml/2016/1/4/259). Paul Bolle

Re: ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

2016-09-27 Thread SF Markus Elfring
>> Will it matter here if the function "kfree" will be called for the >> data structure members "bcs" and "inbuf" after a later function call >> failed within the implementation of "gigaset_initcs"? > > My translation of this question is: could you please hold my hand while > I read the code of a

Re: ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

2016-09-27 Thread Paul Bolle
On Tue, 2016-09-27 at 07:20 +0200, SF Markus Elfring wrote: > Will it matter here if the function "kfree" will be called for the > data structure members "bcs" and "inbuf" after a later function call > failed within the implementation of "gigaset_initcs"? My translation of this question is: could

Re: ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

2016-09-27 Thread SF Markus Elfring
> This patch creates new bugs. Thanks for your information. > I have a policy of not telling Markus where the bug is, I find this kind of response strange. > because otherwise he'll just resend the patch This can also happen when the other contributors request it. > and I have told him man

Re: ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

2016-09-26 Thread SF Markus Elfring
>> Memory was not released (as it would be expected) when one call >> of further resource reservations failed. > > This was the only thing in this series that triggered more than a, > very uninspired, "meh" on first read. Will it matter here if the function "kfree" will be called for the data str