Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-30 Thread SF Markus Elfring
>> Do you find the following details useful for further clarification? > > Almost, you should compare sizes of mlx4_ib.ko and not > drivers/infiniband/hw/mlx4/main.o. text: -32 data: 0 bss: 0 The determined difference is the same finally. Regards, Markus

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-30 Thread Leon Romanovsky
On Mon, Oct 30, 2017 at 09:04:36AM +0100, SF Markus Elfring wrote: > >>> I mean you aren't really making the code any smaller > >> > >> Would anybody like to check corresponding effects in more detail > >> after a specific function call was replaced by a goto statement? > > > > You are supposed to

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-30 Thread SF Markus Elfring
>>> I mean you aren't really making the code any smaller >> >> Would anybody like to check corresponding effects in more detail >> after a specific function call was replaced by a goto statement? > > You are supposed to do it and not "anybody". I can offer another bit of information for this soft

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-28 Thread SF Markus Elfring
>> I guess that the shown change possibility can reduce the object code size >> for the affected function. … > You guess? I am convinced somehow! > Well perhaps you should find out for certain. I am trying to point another general implementation detail out: A jump to an existing call of a func

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-27 Thread Dennis Dalessandro
On 10/27/2017 4:53 PM, SF Markus Elfring wrote: This change adds nothing except code churn. I guess that the shown change possibility can reduce the object code size for the affected function. Do you care for such an detail? Regards, Markus You guess? Well perhaps you should find out for ce

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-27 Thread SF Markus Elfring
> This change adds nothing except code churn. I guess that the shown change possibility can reduce the object code size for the affected function. Do you care for such an detail? Regards, Markus

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-27 Thread Leon Romanovsky
On Fri, Oct 27, 2017 at 09:34:18AM +0200, SF Markus Elfring wrote: > >> Add a jump target so that a bit of exception handling can be better reused > >> at the end of this function. > > > > I'm not sure this is that big of a win. > > Such a view is appropriate because I proposed just another small a

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-27 Thread SF Markus Elfring
>> Add a jump target so that a bit of exception handling can be better reused >> at the end of this function. > > I'm not sure this is that big of a win. Such a view is appropriate because I proposed just another small adjustment for this source code place. > I mean you aren't really making the