Re: FW: Regulator API ignored return values

2013-03-22 Thread Arnd Bergmann
On Friday 22 March 2013, Chris Ball wrote: > > > > The reason I didn't make it a fatal error is that this is just vqmmc > > (responsible for moving from 3.3V to 1.8V for UHS modes), not the > > main vmmc regulator. We can just disable those UHS modes from the > > capabilities on the host if vqmmc

Re: FW: Regulator API ignored return values

2013-03-22 Thread Chris Ball
Hi, On Tue, Mar 12 2013, Chris Ball wrote: > On Tue, Mar 12 2013, Arnd Bergmann wrote: >>> Need add regulator_put here since regulator_get has succeed? >> >> Hmm, we still don't actually bail out if the error is encountered, so >> the reference count is balanced with the current patch, but I maybe

Re: FW: Regulator API ignored return values

2013-03-12 Thread Chris Ball
Hi, On Tue, Mar 12 2013, Arnd Bergmann wrote: >> Need add regulator_put here since regulator_get has succeed? > > Hmm, we still don't actually bail out if the error is encountered, so > the reference count is balanced with the current patch, but I maybe > a failed regulator_enable() should actuall

Re: FW: Regulator API ignored return values

2013-03-12 Thread Arnd Bergmann
On Tuesday 12 March 2013, Kevin Liu wrote: > > - regulator_enable(host->vqmmc); > > + ret = regulator_enable(host->vqmmc); > > if (!regulator_is_supported_voltage(host->vqmmc, 170, > > 195)) > > caps

Re: FW: Regulator API ignored return values

2013-03-11 Thread Kevin Liu
> -Original Message- > From: linux-mmc-ow...@vger.kernel.org > [mailto:linux-mmc-ow...@vger.kernel.org] On Behalf Of Chris Ball > Sent: Tuesday, March 12, 2013 5:56 AM > To: Arnd Bergmann > Cc: linux-kernel@vger.kernel.org; Stephen Warren; > linux-arm-ker...@lists.infradead.org; Mark Brow