Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-09 Thread Arvind Sankar
On Wed, Oct 09, 2019 at 08:50:43AM +0200, Christoph Hellwig wrote: > On Tue, Oct 08, 2019 at 11:47:31AM -0400, Arvind Sankar wrote: > > Ok, I see that almost nothing actually uses dma_get_required_mask. So if > > something did need >4Gb space, the IOMMU would allocate it anyway > > regardless of dm

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-08 Thread Christoph Hellwig
On Tue, Oct 08, 2019 at 11:47:31AM -0400, Arvind Sankar wrote: > Ok, I see that almost nothing actually uses dma_get_required_mask. So if > something did need >4Gb space, the IOMMU would allocate it anyway > regardless of dma_get_required_mask. Yes. And with the direct mapping it also isn't an is

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-08 Thread Arvind Sankar
On Tue, Oct 08, 2019 at 07:51:03AM -0400, Arvind Sankar wrote: > On Tue, Oct 08, 2019 at 09:32:10AM +0200, Christoph Hellwig wrote: > > On Mon, Oct 07, 2019 at 07:54:02PM -0400, Arvind Sankar wrote: > > > > Do you want me to resend the patch as its own mail, or do you just take > > > > it with a Te

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-08 Thread Christoph Hellwig
On Tue, Oct 08, 2019 at 07:51:03AM -0400, Arvind Sankar wrote: > What I mean is, do there exist devices (which would necessarily support > 64-bit DMA) that want to DMA using bigger than 4Gb buffers. Eg a GPU > accelerator card with 16Gb of RAM on-board that wants to map 6Gb for DMA > in one go, or

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-08 Thread Arvind Sankar
On Tue, Oct 08, 2019 at 09:32:10AM +0200, Christoph Hellwig wrote: > On Mon, Oct 07, 2019 at 07:54:02PM -0400, Arvind Sankar wrote: > > > Do you want me to resend the patch as its own mail, or do you just take > > > it with a Tested-by: from me? If the former, I assume you're ok with me > > > addin

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-08 Thread Christoph Hellwig
On Mon, Oct 07, 2019 at 07:54:02PM -0400, Arvind Sankar wrote: > > Do you want me to resend the patch as its own mail, or do you just take > > it with a Tested-by: from me? If the former, I assume you're ok with me > > adding your Signed-off-by? > > > > Thanks > > A question on the original chang

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-08 Thread Christoph Hellwig
On Mon, Oct 07, 2019 at 06:10:55PM -0400, Arvind Sankar wrote: > > Acked-by: Christoph Hellwig > > Do you want me to resend the patch as its own mail, or do you just take > it with a Tested-by: from me? If the former, I assume you're ok with me > adding your Signed-off-by? Either way is fine wit

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-07 Thread Arvind Sankar
On Mon, Oct 07, 2019 at 06:10:55PM -0400, Arvind Sankar wrote: > On Mon, Oct 07, 2019 at 08:47:54PM +0200, Christoph Hellwig wrote: > > On Mon, Oct 07, 2019 at 02:32:07PM -0400, Arvind Sankar wrote: > > > On Mon, Oct 07, 2019 at 01:58:57PM -0400, Arvind Sankar wrote: > > > > On Mon, Oct 07, 2019 at

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-07 Thread Arvind Sankar
On Mon, Oct 07, 2019 at 08:47:54PM +0200, Christoph Hellwig wrote: > On Mon, Oct 07, 2019 at 02:32:07PM -0400, Arvind Sankar wrote: > > On Mon, Oct 07, 2019 at 01:58:57PM -0400, Arvind Sankar wrote: > > > On Mon, Oct 07, 2019 at 10:56:30AM -0700, Christoph Hellwig wrote: > > > > On Mon, Oct 07, 201

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-07 Thread Christoph Hellwig
On Mon, Oct 07, 2019 at 02:32:07PM -0400, Arvind Sankar wrote: > On Mon, Oct 07, 2019 at 01:58:57PM -0400, Arvind Sankar wrote: > > On Mon, Oct 07, 2019 at 10:56:30AM -0700, Christoph Hellwig wrote: > > > On Mon, Oct 07, 2019 at 07:55:28PM +0200, Christoph Hellwig wrote: > > > > On Mon, Oct 07, 201

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-07 Thread Arvind Sankar
On Mon, Oct 07, 2019 at 01:58:57PM -0400, Arvind Sankar wrote: > On Mon, Oct 07, 2019 at 10:56:30AM -0700, Christoph Hellwig wrote: > > On Mon, Oct 07, 2019 at 07:55:28PM +0200, Christoph Hellwig wrote: > > > On Mon, Oct 07, 2019 at 01:54:32PM -0400, Arvind Sankar wrote: > > > > It doesn't boot wit

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-07 Thread Arvind Sankar
On Mon, Oct 07, 2019 at 10:56:30AM -0700, Christoph Hellwig wrote: > On Mon, Oct 07, 2019 at 07:55:28PM +0200, Christoph Hellwig wrote: > > On Mon, Oct 07, 2019 at 01:54:32PM -0400, Arvind Sankar wrote: > > > It doesn't boot with the patch. Won't it go > > > dma_get_required_mask > > > -> intel

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-07 Thread Christoph Hellwig
On Mon, Oct 07, 2019 at 07:55:28PM +0200, Christoph Hellwig wrote: > On Mon, Oct 07, 2019 at 01:54:32PM -0400, Arvind Sankar wrote: > > It doesn't boot with the patch. Won't it go > > dma_get_required_mask > > -> intel_get_required_mask > > -> iommu_need_mapping > > -> dma_get_requi

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-07 Thread Christoph Hellwig
On Mon, Oct 07, 2019 at 01:54:32PM -0400, Arvind Sankar wrote: > It doesn't boot with the patch. Won't it go > dma_get_required_mask > -> intel_get_required_mask > -> iommu_need_mapping > -> dma_get_required_mask > ? > > Should the call to dma_get_required_mask in iommu_nee

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-07 Thread Arvind Sankar
On Mon, Oct 07, 2019 at 09:34:48AM +0200, Christoph Hellwig wrote: > Hi Arvind, > > can you try the patch below? > > > diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c > index 3f974919d3bd..52b709bf2b55 100644 > --- a/drivers/iommu/intel-iommu.c > +++ b/drivers/iommu/intel-

Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2

2019-10-07 Thread Christoph Hellwig
Hi Arvind, can you try the patch below? diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index 3f974919d3bd..52b709bf2b55 100644 --- a/drivers/iommu/intel-iommu.c +++ b/drivers/iommu/intel-iommu.c @@ -3775,6 +3775,13 @@ static int intel_map_sg(struct device *dev, struct sc

RE: EHCI

2017-03-17 Thread Lipengcheng
Hi, > -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Saturday, March 18, 2017 12:44 AM > To: Lipengcheng > Cc: gre...@linuxfoundation.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: EHCI > > On Fr

Re: EHCI

2017-03-17 Thread Alan Stern
On Fri, 17 Mar 2017, Lipengcheng wrote: > Hi, > In the ehci-hub.c,the ehci_handshake(ehci, status_reg, PORT_RESET, 0, > 1000) use that the timeout is 1000us. The 1000us timeout can not > satisfy all the chips. The EHCI protocol describes:A host controller > must terminate the reset and stabilize t

Re: EHCI hotplug kernel crash in kernel 3.14 and 3.13

2014-04-14 Thread Stefani Seibold
Hi Alan, the patch fix the issue. I tested it on a notebook with a cardbus controller and on desktop machine with a thunderbolt interface. Both are working. Thunderbolt will sometimes crash but i think this is a issue with dynamic added pci bridges, which cause a lot of trouble and headache to m

Re: EHCI hotplug kernel crash in kernel 3.14 and 3.13

2014-04-14 Thread Alan Stern
On Sun, 13 Apr 2014, Stefani Seibold wrote: > A hot plug of an USB 2.0 EHCI controller cardbus card will result in a > kernel crash. This is the kernel log of a vanilla 3.14 x86_64 kernel. I > will attach my kernel config. > [ 70.419755] ehci-pci :04:00.2: EHCI Host Controller > [ 70.4198

Re: ehci-pci failed handover

2013-04-23 Thread Jesús J . Guerrero Botella
I just used the old good method of including everything under the usb drivers set as 'm', and it works now. Sorry for the noise. I guess I wasn't including some relevant driver for this concrete usb chip. Amazingly, the pendrives worked from the first moment without any problem at all... go figure

RE: EHCI Regression in 2.6.23-rc2

2007-08-15 Thread Stuart_Hayes
Hayes, Stuart wrote: > David Brownell wrote: >>> Hm... I've got a 0.95. I'll try to get a Via EHCI 1.00 controller >>> and make sure it's the same problem. >> >> Yeah, for some reason way too many of the add-on PCI cards with VIA >> chips use that pretty-broken VT6202 chip. Ones with VT6212 are

RE: EHCI Regression in 2.6.23-rc2

2007-08-14 Thread Stuart_Hayes
David Brownell wrote: >> Hm... I've got a 0.95. I'll try to get a Via EHCI 1.00 controller >> and make sure it's the same problem. > > Yeah, for some reason way too many of the add-on PCI cards with VIA > chips use that pretty-broken VT6202 chip. Ones with VT6212 are also > available, and work a

Re: EHCI Regression in 2.6.23-rc2

2007-08-14 Thread David Brownell
> > I think 8237 was about where they forked off the the VT6212 as > > their first discrete EHCI (for addon cards) claiming EHCI 1.0 > > conformance. Too bad they didn't recycle all the VT6202 chips > > in their inventory at that time... > > No hardware producer would have done that ;) As I said:

Re: EHCI Regression in 2.6.23-rc2

2007-08-14 Thread Daniel Exner
David Brownell wrote: > > ehci_hcd :00:10.4: USB 2.0 started, EHCI 1.00, driver 10 Dec 2004 > > > > Build into: > > 00:01.0 PCI bridge: VIA Technologies, Inc. VT8237 PCI bridge > > [K8T800/K8T890 South] > > Yeah, VT8235 was their first southbridge with integrated EHCI. > ISTR that the VT8237 wo

Re: EHCI Regression in 2.6.23-rc2

2007-08-14 Thread David Brownell
> Hm... I've got a 0.95. I'll try to get a Via EHCI 1.00 controller and > make sure it's the same problem. Yeah, for some reason way too many of the add-on PCI cards with VIA chips use that pretty-broken VT6202 chip. Ones with VT6212 are also available, and work a lot better. > > Regarding the

Re: EHCI Regression in 2.6.23-rc2

2007-08-14 Thread David Brownell
> ehci_hcd :00:10.4: USB 2.0 started, EHCI 1.00, driver 10 Dec 2004 > > Build into: > 00:01.0 PCI bridge: VIA Technologies, Inc. VT8237 PCI bridge [K8T800/K8T890 > South] Yeah, VT8235 was their first southbridge with integrated EHCI. ISTR that the VT8237 worked a bit more smoothly. I think 8

RE: EHCI Regression in 2.6.23-rc2

2007-08-14 Thread Stuart_Hayes
Daniel Exner wrote: > David Brownell wrote: >> On Monday 13 August 2007, Daniel Exner wrote: > [..] >>> Where exactly should I search for this? Neither lspci nor lsusb >>> showed any hint on the EHCI rev. the chip conforms to.. >> >> The driver logs that information as it starts; on this sytem: >>

Re: EHCI Regression in 2.6.23-rc2

2007-08-14 Thread Daniel Exner
David Brownell wrote: > On Monday 13 August 2007, Daniel Exner wrote: [..] > > Where exactly should I search for this? Neither lspci nor lsusb showed > > any hint on the EHCI rev. the chip conforms to.. > > The driver logs that information as it starts; on this sytem: > > ehci_hcd :00:02.2: US

Re: EHCI Regression in 2.6.23-rc2

2007-08-14 Thread David Brownell
On Monday 13 August 2007, Daniel Exner wrote: > David Brownell wrote: > > On Monday 13 August 2007, [EMAIL PROTECTED] wrote: > > > With the VIA controller I have, > > > > Which kind is that? The VT6202 is buggy as all get-out, and > > they sold a *LOT* of those discrete chips for use in add-on PCI

Re: EHCI Regression in 2.6.23-rc2

2007-08-13 Thread Daniel Exner
David Brownell wrote: > On Monday 13 August 2007, [EMAIL PROTECTED] wrote: > > With the VIA controller I have, > > Which kind is that? The VT6202 is buggy as all get-out, and > they sold a *LOT* of those discrete chips for use in add-on PCI > cards. We generally warn people away from those. A mo

Re: EHCI Regression in 2.6.23-rc2

2007-08-13 Thread David Brownell
On Monday 13 August 2007, [EMAIL PROTECTED] wrote: > With the VIA controller I have, Which kind is that? The VT6202 is buggy as all get-out, and they sold a *LOT* of those discrete chips for use in add-on PCI cards. We generally warn people away from those. A more current version is the VT6212,

RE: EHCI Regression in 2.6.23-rc2

2007-08-13 Thread Stuart_Hayes
Daniel Exner wrote: > Jiri Kosina wrote: >> On Fri, 10 Aug 2007, Daniel Exner wrote: >>> Please CC me, as I'm currently not subscribed to this list, thx. >> >> Please also don't forget to CC relevant people/lists when reporting >> bugs, thanks. > Guess its ok, now? Thanks anyway :) > >>> After so

RE: EHCI Regression in 2.6.23-rc2

2007-08-10 Thread Stuart_Hayes
Jiri Kosina wrote: > On Fri, 10 Aug 2007, Daniel Exner wrote: > >> After some serious hangs with 2.6.23-rc2 I did some bisects and this >> was the result: >> 196705c9bbc03540429b0f7cf9ee35c2f928a534 is first bad commit commit >> 196705c9bbc03540429b0f7cf9ee35c2f928a534 >> Author: [EMAIL PROTECTED]

Re: EHCI Regression in 2.6.23-rc2

2007-08-10 Thread Daniel Exner
Jiri Kosina wrote: > On Fri, 10 Aug 2007, Daniel Exner wrote: > > Please CC me, as I'm currently not subscribed to this list, thx. > > Please also don't forget to CC relevant people/lists when reporting bugs, > thanks. Guess its ok, now? Thanks anyway :) > > After some serious hangs with 2.6.23-rc

Re: EHCI Regression in 2.6.23-rc2

2007-08-10 Thread Jiri Kosina
On Fri, 10 Aug 2007, Daniel Exner wrote: > Please CC me, as I'm currently not subscribed to this list, thx. Please also don't forget to CC relevant people/lists when reporting bugs, thanks. > After some serious hangs with 2.6.23-rc2 I did some bisects and this was the > result: > 196705c9bbc03