Re: Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c

2016-04-27 Thread Kees Cook
On Wed, Apr 27, 2016 at 1:07 AM, Julia Lawall wrote: > > > On Wed, 27 Apr 2016, Dan Carpenter wrote: > >> On Wed, Apr 27, 2016 at 07:42:04AM +0200, Julia Lawall wrote: >> > >> > >> > On Tue, 26 Apr 2016, Kees Cook wrote: >> > >> > > On Mon, Apr 25, 2016 at 7:50 AM, Pengfei Wang >> > > wrote: >>

Re: Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c

2016-04-27 Thread Julia Lawall
On Wed, 27 Apr 2016, Dan Carpenter wrote: > On Wed, Apr 27, 2016 at 07:42:04AM +0200, Julia Lawall wrote: > > > > > > On Tue, 26 Apr 2016, Kees Cook wrote: > > > > > On Mon, Apr 25, 2016 at 7:50 AM, Pengfei Wang > > > wrote: > > > > Hello, > > > > > > > > I found this Double-Fetch bug in > >

Re: Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c

2016-04-27 Thread Dan Carpenter
On Wed, Apr 27, 2016 at 07:42:04AM +0200, Julia Lawall wrote: > > > On Tue, 26 Apr 2016, Kees Cook wrote: > > > On Mon, Apr 25, 2016 at 7:50 AM, Pengfei Wang > > wrote: > > > Hello, > > > > > > I found this Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c > > > when I was examinin

Re: Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c

2016-04-26 Thread Julia Lawall
On Tue, 26 Apr 2016, Kees Cook wrote: > On Mon, Apr 25, 2016 at 7:50 AM, Pengfei Wang wrote: > > Hello, > > > > I found this Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c > > when I was examining the source code. > > Thanks for these reports! I wrote a coccinelle script to find

Re: Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c

2016-04-26 Thread Kees Cook
On Mon, Apr 25, 2016 at 7:50 AM, Pengfei Wang wrote: > Hello, > > I found this Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c > when I was examining the source code. Thanks for these reports! I wrote a coccinelle script to find these, but it requires some manual checking. For what