Re: Divide-by-zero in the 2.6.23 scheduler code

2007-11-14 Thread Dmitry Adamushko
[ forwarded to the list ] so far, just a brief inspection below... > > The divide-by-zero is here in kernel/sched.c: > [ ... ] > > fair_delta64 = ls->delta_fair + 1; > ls->delta_fair = 0; > > exec_delta64 = ls->delta_exec + 1; > ls->delta_exec = 0; > > samp

Re: Divide-by-zero in the 2.6.23 scheduler code

2007-11-14 Thread Ingo Molnar
* Peter Zijlstra <[EMAIL PROTECTED]> wrote: > As for the patch, better to just rip out the entire feature.. for -stable it's safer to have smaller patches - so this patch is perfectly fine. A user can turn it back on under SCHED_DEBUG and by tweaking a debug flag - but that's not a big issue,

Re: Divide-by-zero in the 2.6.23 scheduler code

2007-11-14 Thread Peter Zijlstra
On Tue, 2007-11-13 at 20:14 -0500, Chuck Ebbert wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=340161 While I see the user has a divide by zero, I'm not understanding it. > The problem code has been removed in 2.6.24. The below patch disables > SCHED_FEAT_PRECISE_CPU_LOAD which causes the