Re: Config printk buffer size

2001-04-05 Thread Thomas Dodd
Alan Cox wrote: > > Looks ok to me but given the ability of the average kernel hacker to read > help texts I;d rather it was a choice menu of say OK, I guess I gave too much credit :) This gives 4 options, 4K, 8K, 16K, and 32K. 4K is for the embedded guys, but they might want even less. 32K is

Re: Config printk buffer size

2001-04-05 Thread Thomas Dodd
Andrzej Krzysztofowicz wrote: > > IMO, it would be nice to add a test here whether the CONFIG_PRINTK_BUF_LEN > value is really set as a power of two, eg.: > > #if (LOG_BUF_LEN & LOG_BUF_MASK) > #error CONFIG_PRINTK_BUF_LEN must be a power of two > #endif I couldn't figure out how to do it in th

Re: Config printk buffer size

2001-04-05 Thread Andrzej Krzysztofowicz
"Thomas Dodd wrote:" > diff -u --new-file --recursive linux-2.4.3-ac2.orig/kernel/printk.c >linux-2.4.3-ac2/kernel/printk.c > --- linux-2.4.3-ac2.orig/kernel/printk.c Wed Apr 4 15:23:31 2001 > +++ linux-2.4.3-ac2/kernel/printk.c Wed Apr 4 16:01:28 2001 > @@ -27,7 +27,7 @@ > > #includ