Re: Build failures with gcc 4.5 and older

2018-08-20 Thread Linus Torvalds
On Mon, Aug 20, 2018 at 10:46 AM Nick Desaulniers wrote: > > I think we should take Joe's patch. I'll happily take Joe's patch and get the whole "ancient gcc versions" issue behind us. We'll come back to it in a few years when 4.6 is ancient too, but for now we have no pressing need not to suppo

Re: Build failures with gcc 4.5 and older

2018-08-20 Thread Nick Desaulniers
I think we should take Joe's patch. Reviewed-by: Nick Desaulniers (sorry for the lack of context, trying out the reply instructions from: https://lore.kernel.org/lkml/4cdd4ab9ddd16f1fb168266643264595782fd890.ca...@perches.com/)

Re: Build failures with gcc 4.5 and older

2018-08-20 Thread Arnd Bergmann
On Mon, Aug 20, 2018 at 4:58 PM Thomas Gleixner wrote: > > On Tue, 14 Aug 2018, Guenter Roeck wrote: > > > > For my part I am all for making gcc 4.6 mandatory. > > No objections from my side. gcc-4.6 is also what I suggested a while ago as a good choice for a new minimum version, back then I met

Re: Build failures with gcc 4.5 and older

2018-08-20 Thread Thomas Gleixner
On Tue, 14 Aug 2018, Guenter Roeck wrote: > On 08/14/2018 04:20 PM, Linus Torvalds wrote: > > On Tue, Aug 14, 2018 at 4:02 PM Andrew Morton > > wrote: > > > > > > The m68k build still fails because 0cc3cd21657 ("cpu/hotplug: Boot HT > > > siblings at least once") was evidently never tested on CON

Re: Build failures with gcc 4.5 and older

2018-08-19 Thread Kees Cook
On Tue, Aug 14, 2018 at 10:48 AM, Joe Perches wrote: > On Tue, 2018-08-14 at 10:09 -0700, Guenter Roeck wrote: >> Hi, >> >> Since commit c1a2f7f0c0645 ("mm: Allocate the mm_cpumask >> (mm->cpu_bitmap[]) dynamically based on nr_cpu_ids"), building >> the Linux kernel with gcc version 4.5 and older

RE: Build failures with gcc 4.5 and older

2018-08-16 Thread David Laight
From: Linus Torvalds > Sent: 15 August 2018 17:34 > To: David Laight > Cc: Guenter Roeck; Linux Kernel Mailing List; Rik van Riel; Mike Galbraith; > Dave Hansen; Andrew Morton > Subject: Re: Build failures with gcc 4.5 and older > > On Wed, Aug 15, 2018 at 9:16 A

Re: Build failures with gcc 4.5 and older

2018-08-15 Thread Guenter Roeck
On 08/15/2018 09:34 AM, Linus Torvalds wrote: On Wed, Aug 15, 2018 at 9:09 AM Tony Luck wrote: I did manage to build 4.6.4. 4.6.4 built git HEAD* that failed yesterday using 4.3.4. It boots OK. Good. 4.6 is what we'd suggest be the new baseline, and we can hopefully keep that for a while.

Re: Build failures with gcc 4.5 and older

2018-08-15 Thread Guenter Roeck
On Wed, Aug 15, 2018 at 09:09:17AM -0700, Tony Luck wrote: > On Tue, Aug 14, 2018 at 1:19 PM Tony Luck wrote: > > My ia64 test box only has 4.3.4. I seem to remember some pain points > > with newer versions of gcc on ia64. I need to poke around and find one > > new enough to get past this problem

Re: Build failures with gcc 4.5 and older

2018-08-15 Thread Linus Torvalds
On Wed, Aug 15, 2018 at 9:09 AM Tony Luck wrote: > > I did manage to build 4.6.4. > > 4.6.4 built git HEAD* that failed yesterday using 4.3.4. It boots OK. Good. 4.6 is what we'd suggest be the new baseline, and we can hopefully keep that for a while. Linus

Re: Build failures with gcc 4.5 and older

2018-08-15 Thread Linus Torvalds
On Wed, Aug 15, 2018 at 9:16 AM David Laight wrote: > > > > > But some libelf bug that is less than a year old is likely to bite people. > > See https://lkml.org/lkml/2017/9/10/186 for the libelf fix. > It isn't anything like as rare as those emails suggest. > An 'allmodconfig' build fails on a lo

RE: Build failures with gcc 4.5 and older

2018-08-15 Thread David Laight
From: Linus Torvalds > Sent: 15 August 2018 16:44 > On Wed, Aug 15, 2018 at 5:38 AM David Laight wrote: > > > > Never mind the version of gcc, the x86 kernel doesn't build with the > > default kernel options because the ORC unwinder hits a bug in libelf > > (in objtool) that was only fixed late l

Re: Build failures with gcc 4.5 and older

2018-08-15 Thread Tony Luck
On Tue, Aug 14, 2018 at 1:19 PM Tony Luck wrote: > My ia64 test box only has 4.3.4. I seem to remember some pain points > with newer versions of gcc on ia64. I need to poke around and find one > new enough to get past this problem, but that still works for kernel building. I had problems trying

Re: Build failures with gcc 4.5 and older

2018-08-15 Thread Linus Torvalds
On Wed, Aug 15, 2018 at 5:38 AM David Laight wrote: > > Never mind the version of gcc, the x86 kernel doesn't build with the > default kernel options because the ORC unwinder hits a bug in libelf > (in objtool) that was only fixed late last year. > > It isn't even obvious from the build log what h

RE: Build failures with gcc 4.5 and older

2018-08-15 Thread David Laight
From: Guenter Roeck > Sent: 14 August 2018 18:09 ... > Does that mean that gcc 4.5 and older are now officially no longer > supported for compiling the kernel ? Never mind the version of gcc, the x86 kernel doesn't build with the default kernel options because the ORC unwinder hits a bug in libelf

Re: Build failures with gcc 4.5 and older

2018-08-14 Thread Guenter Roeck
On 08/14/2018 04:20 PM, Linus Torvalds wrote: On Tue, Aug 14, 2018 at 4:02 PM Andrew Morton wrote: The m68k build still fails because 0cc3cd21657 ("cpu/hotplug: Boot HT siblings at least once") was evidently never tested on CONFIG_SMP=n. How could that come about - the patch is six weeks old??

Re: Build failures with gcc 4.5 and older

2018-08-14 Thread Linus Torvalds
On Tue, Aug 14, 2018 at 4:02 PM Andrew Morton wrote: > > The m68k build still fails because 0cc3cd21657 ("cpu/hotplug: Boot HT > siblings at least once") was evidently never tested on CONFIG_SMP=n. > How could that come about - the patch is six weeks old?? Ehh, meet the joys of embargoes. The co

Re: Build failures with gcc 4.5 and older

2018-08-14 Thread Andrew Morton
On Tue, 14 Aug 2018 15:15:59 -0700 Guenter Roeck wrote: > > Confused. Why does it think that the mm_struct is "otherwise empty"? > > > > The problem isn't really that the structure is otherwise empty. > Some digging reveals that the error message is wrong; gcc should > instead complain about h

Re: Build failures with gcc 4.5 and older

2018-08-14 Thread Guenter Roeck
On Tue, Aug 14, 2018 at 02:36:55PM -0700, Andrew Morton wrote: > On Tue, 14 Aug 2018 10:09:04 -0700 Guenter Roeck wrote: > > > Since commit c1a2f7f0c0645 ("mm: Allocate the mm_cpumask > > (mm->cpu_bitmap[]) dynamically based on nr_cpu_ids"), building > > the Linux kernel with gcc version 4.5 and

Re: Build failures with gcc 4.5 and older

2018-08-14 Thread Andrew Morton
On Tue, 14 Aug 2018 10:09:04 -0700 Guenter Roeck wrote: > Since commit c1a2f7f0c0645 ("mm: Allocate the mm_cpumask > (mm->cpu_bitmap[]) dynamically based on nr_cpu_ids"), building > the Linux kernel with gcc version 4.5 and older fails as follows. > > In file included from ./include/linux/mm.h:1

Re: Build failures with gcc 4.5 and older

2018-08-14 Thread Tony Luck
On Tue, Aug 14, 2018 at 11:02 AM Guenter Roeck wrote: > > On Tue, Aug 14, 2018 at 10:20:32AM -0700, Linus Torvalds wrote: > > On Tue, Aug 14, 2018 at 10:09 AM Guenter Roeck wrote: > > > > > > Does that mean that gcc 4.5 and older are now officially no longer > > > supported for compiling the kern

Re: Build failures with gcc 4.5 and older

2018-08-14 Thread Guenter Roeck
On Tue, Aug 14, 2018 at 10:20:32AM -0700, Linus Torvalds wrote: > On Tue, Aug 14, 2018 at 10:09 AM Guenter Roeck wrote: > > > > Does that mean that gcc 4.5 and older are now officially no longer > > supported for compiling the kernel ? > > I guess we might as well make this the excuse for making

Re: Build failures with gcc 4.5 and older

2018-08-14 Thread Joe Perches
On Tue, 2018-08-14 at 10:09 -0700, Guenter Roeck wrote: > Hi, > > Since commit c1a2f7f0c0645 ("mm: Allocate the mm_cpumask > (mm->cpu_bitmap[]) dynamically based on nr_cpu_ids"), building > the Linux kernel with gcc version 4.5 and older fails as follows. > > In file included from ./include/linux

Re: Build failures with gcc 4.5 and older

2018-08-14 Thread Linus Torvalds
On Tue, Aug 14, 2018 at 10:09 AM Guenter Roeck wrote: > > Does that mean that gcc 4.5 and older are now officially no longer > supported for compiling the kernel ? I guess we might as well make this the excuse for making that official. Maybe it's trivially fixable, but I don't even want to look