Re: Bad virt_to_phys since commit 54c7a8916a887f35

2019-05-23 Thread Will Deacon
On Thu, May 23, 2019 at 10:58:19AM +0100, Steven Price wrote: > On 23/05/2019 10:54, Mike Rapoport wrote: > > On Thu, May 23, 2019 at 10:31:38AM +0100, Will Deacon wrote: > >> Hi Steven, > >> > >> On Thu, May 16, 2019 at 03:20:59PM +0100, Steven Price wrote: > >>> I'll spin a real patch and add you

Re: Bad virt_to_phys since commit 54c7a8916a887f35

2019-05-23 Thread Steven Price
On 23/05/2019 10:54, Mike Rapoport wrote: > On Thu, May 23, 2019 at 10:31:38AM +0100, Will Deacon wrote: >> Hi Steven, >> >> On Thu, May 16, 2019 at 03:20:59PM +0100, Steven Price wrote: >>> I'll spin a real patch and add your Tested-by >> >> Did you send this out? I can't spot it in my inbox. >

Re: Bad virt_to_phys since commit 54c7a8916a887f35

2019-05-23 Thread Mike Rapoport
On Thu, May 23, 2019 at 10:31:38AM +0100, Will Deacon wrote: > Hi Steven, > > On Thu, May 16, 2019 at 03:20:59PM +0100, Steven Price wrote: > > I'll spin a real patch and add your Tested-by > > Did you send this out? I can't spot it in my inbox. https://lore.kernel.org/lkml/20190516143125.48948

Re: Bad virt_to_phys since commit 54c7a8916a887f35

2019-05-23 Thread Will Deacon
Hi Steven, On Thu, May 16, 2019 at 03:20:59PM +0100, Steven Price wrote: > I'll spin a real patch and add your Tested-by Did you send this out? I can't spot it in my inbox. Cheers, Will

Re: Bad virt_to_phys since commit 54c7a8916a887f35

2019-05-16 Thread Mark Rutland
On Thu, May 16, 2019 at 03:20:59PM +0100, Steven Price wrote: > On 16/05/2019 15:16, Mark Rutland wrote: > > On Thu, May 16, 2019 at 03:05:31PM +0100, Steven Price wrote: > >> I suspect the following is sufficient to fix the problem: > >> > >> 8<- > >> diff --git a/init/initramfs.c b/init/i

Re: Bad virt_to_phys since commit 54c7a8916a887f35

2019-05-16 Thread Christoph Hellwig
On Thu, May 16, 2019 at 03:21:19PM +0100, Mark Rutland wrote: > > void __weak free_initrd_mem(unsigned long start, unsigned long end) > > { > > + if (!start) > > + return; > > + > > free_reserved_area((void *)start, (void *)end, POISON_FREE_INITMEM, > >

Re: Bad virt_to_phys since commit 54c7a8916a887f35

2019-05-16 Thread Mark Rutland
On Thu, May 16, 2019 at 05:13:14PM +0300, Mike Rapoport wrote: > On Thu, May 16, 2019 at 02:41:06PM +0100, Mark Rutland wrote: > > On Thu, May 16, 2019 at 02:38:20PM +0100, Mark Rutland wrote: > > > Hi, > > > > > > Since commit: > > > > > > 54c7a8916a887f35 ("initramfs: free initrd memory if op

Re: Bad virt_to_phys since commit 54c7a8916a887f35

2019-05-16 Thread Mark Rutland
On Thu, May 16, 2019 at 03:05:31PM +0100, Steven Price wrote: > On 16/05/2019 14:41, Mark Rutland wrote: > > On Thu, May 16, 2019 at 02:38:20PM +0100, Mark Rutland wrote: > >> Hi, > >> > >> Since commit: > >> > >> 54c7a8916a887f35 ("initramfs: free initrd memory if opening > >> /initrd.image fai

Re: Bad virt_to_phys since commit 54c7a8916a887f35

2019-05-16 Thread Mike Rapoport
On Thu, May 16, 2019 at 02:41:06PM +0100, Mark Rutland wrote: > On Thu, May 16, 2019 at 02:38:20PM +0100, Mark Rutland wrote: > > Hi, > > > > Since commit: > > > > 54c7a8916a887f35 ("initramfs: free initrd memory if opening /initrd.image > > fails") > > Ugh, I dropped a paragarph here. > > S

Re: Bad virt_to_phys since commit 54c7a8916a887f35

2019-05-16 Thread Steven Price
On 16/05/2019 15:16, Mark Rutland wrote: > On Thu, May 16, 2019 at 03:05:31PM +0100, Steven Price wrote: >> On 16/05/2019 14:41, Mark Rutland wrote: >>> On Thu, May 16, 2019 at 02:38:20PM +0100, Mark Rutland wrote: Hi, Since commit: 54c7a8916a887f35 ("initramfs: free init

Re: Bad virt_to_phys since commit 54c7a8916a887f35

2019-05-16 Thread Steven Price
On 16/05/2019 14:41, Mark Rutland wrote: > On Thu, May 16, 2019 at 02:38:20PM +0100, Mark Rutland wrote: >> Hi, >> >> Since commit: >> >> 54c7a8916a887f35 ("initramfs: free initrd memory if opening /initrd.image >> fails") > > Ugh, I dropped a paragarph here. > > Since that commit, I'm seeing

Re: Bad virt_to_phys since commit 54c7a8916a887f35

2019-05-16 Thread Mark Rutland
On Thu, May 16, 2019 at 02:38:20PM +0100, Mark Rutland wrote: > Hi, > > Since commit: > > 54c7a8916a887f35 ("initramfs: free initrd memory if opening /initrd.image > fails") Ugh, I dropped a paragarph here. Since that commit, I'm seeing a boot-time splat on arm64 when using CONFIG_DEBUG_VIRT