Re: Background scanning change on 2.4.6-pre1

2001-06-08 Thread Rik van Riel
On Thu, 7 Jun 2001, Linus Torvalds wrote: > On Thu, 7 Jun 2001, Marcelo Tosatti wrote: > > time (the old code from Rik which has been replaced by this code tried to > > avoid that) > > Now, I think the problem with the old code was that it didn't do _any_ > background page aging if "inactive" w

Re: Background scanning change on 2.4.6-pre1

2001-06-07 Thread Andreas Dilger
Linus writes: > On Thu, 7 Jun 2001, Marcelo Tosatti wrote: > > Who did this change to refill_inactive_scan() in 2.4.6-pre1 ? > > I think it was Andreas Dilger.. Definitely NOT. I don't touch MM stuff. I do filesystems and LVM only. Cheers, Andreas -- Andreas Dilger \ "If a man ate a pound

Re: Background scanning change on 2.4.6-pre1

2001-06-07 Thread Linus Torvalds
On Thu, 7 Jun 2001, Marcelo Tosatti wrote: > > Who did this change to refill_inactive_scan() in 2.4.6-pre1 ? I think it was Andreas Dilger.. > /* > * When we are background aging, we try to increase the page aging > * information in the system. > */ >

Re: Background scanning change on 2.4.6-pre1

2001-06-07 Thread Andreas Dilger
Marcello writes: > Who did this change to refill_inactive_scan() in 2.4.6-pre1 ? > > /* > * When we are background aging, we try to increase the page aging > * information in the system. > */ > if (!target) > maxscan = nr_active_pages >>

Re: Background scanning change on 2.4.6-pre1

2001-06-07 Thread Jonathan Morton
>> > This is going to make all pages have age 0 on an idle system after some >> > time (the old code from Rik which has been replaced by this code tried to >> > avoid that) > >There's another reason why I think the patch may be ok even without any >added logic: not only does it simplify the code a

Re: Background scanning change on 2.4.6-pre1

2001-06-07 Thread Linus Torvalds
Forgot one comment.. > > This is going to make all pages have age 0 on an idle system after some > > time (the old code from Rik which has been replaced by this code tried to > > avoid that) There's another reason why I think the patch may be ok even without any added logic: not only does it s

Re: Background scanning change on 2.4.6-pre1

2001-06-07 Thread Marcelo Tosatti
On Thu, 7 Jun 2001, Linus Torvalds wrote: > > Forgot one comment.. > > > > This is going to make all pages have age 0 on an idle system after some > > > time (the old code from Rik which has been replaced by this code tried to > > > avoid that) > > There's another reason why I think the pat