Re: BLKSSZGET change will break fdisk

2000-10-18 Thread Jes Sorensen
> "Ralf" == Ralf Baechle <[EMAIL PROTECTED]> writes: Ralf> On Tue, Oct 17, 2000 at 12:53:40AM +0200, Andries Brouwer wrote: >> (By the way, have you checked that replacing get_sectorsize by an >> empty routine, and specifying a -b option, works well?) >> >> (Do you know which disks have unus

Re: BLKSSZGET change will break fdisk

2000-10-17 Thread Ralf Baechle
On Tue, Oct 17, 2000 at 12:53:40AM +0200, Andries Brouwer wrote: > (By the way, have you checked that replacing get_sectorsize > by an empty routine, and specifying a -b option, works well?) > > (Do you know which disks have unusual sector size? > So far I had only seen reports on a Fujitsu 640

Re: BLKSSZGET change will break fdisk

2000-10-17 Thread Roman Zippel
Hi, On Tue, 17 Oct 2000, Andries Brouwer wrote: > But you see that one would need a new name as well, > otherwise the value associated with BLKSSZGET would > depend on the kernel version, and one would need > version checks anyway. We do rename structures too, and this would be similiar. I'm mo

Re: BLKSSZGET change will break fdisk

2000-10-16 Thread Andries Brouwer
On Tue, Oct 17, 2000 at 12:02:01AM +0200, Roman Zippel wrote: > Why don't we give BLKSSZGET a new number and make the old one obsolete? But you see that one would need a new name as well, otherwise the value associated with BLKSSZGET would depend on the kernel version, and one would need version

Re: BLKSSZGET change will break fdisk

2000-10-16 Thread Roman Zippel
Hi, > - BLKSSZGET added in common.h Why don't we give BLKSSZGET a new number and make the old one obsolete? I don't think it's used anywhere, as its result is pretty useless in userspace (and even if it's used somewhere, they have to copy the define anyway). This way we don't need that version c

Re: BLKSSZGET change will break fdisk

2000-10-16 Thread Andries Brouwer
On Mon, Oct 16, 2000 at 10:38:41PM +0200, Roman Zippel wrote: > > [now that you make me look at this, there is a flaw in fdisk there; > > fixed in 2.10p] > > BLKSSZGET isn't defined for fdisk.c? :) Indeed :-) The current code looks like this: - BLKSSZGET added in common.h - in fdisk.c added li

Re: BLKSSZGET change will break fdisk

2000-10-16 Thread Roman Zippel
Hi, > Concerning fdisk, luckily you are mistaken - its source says > > #if defined(BLKSSZGET) && defined(HAVE_blkpg_h) > > so that it will not use the broken BLKSSZGET of 2.2. ??? BLKSSZGET has exactly the same ioctl number in 2.2 and 2.4, so if I compile fdisk under 2.4 and try to use it unde

Re: BLKSSZGET change will break fdisk

2000-10-16 Thread Andries Brouwer
On Mon, Oct 16, 2000 at 08:04:27PM +0200, Roman Zippel wrote: > I noticed that behaviour of BLKSSZGET changed between 2.2 and 2.4. One of > the users will be fdisk, as soon as it is compiled with 2.4 kernel > headers, but then fdisk will be no longer usable under 2.2! > My question now is, wouldn