Re: Adding a .platform_init callback to sdhci_arasan_ops

Hi, On 05/12/16 17:30, Doug Anderson wrote: > > AKA: you are setting up various "corecfg" stuff that's documented in > the generic Arasan docs. Others SDHCI-Arasan implementations might > want to set the same things, but those values may be stored elsewhere > for them. Exactly, that is what I'

Re: Adding a .platform_init callback to sdhci_arasan_ops

Hi, On Mon, Dec 5, 2016 at 4:29 AM, Sebastian Frias wrote: > Hi Doug, > > On 28/11/16 19:02, Doug Anderson wrote: >> Hi, >> >> On Mon, Nov 28, 2016 at 5:28 AM, Sebastian Frias wrote: >>> +static void sdhci_tango4_platform_init(struct sdhci_host *host) >>> +{ >>> + printk("%s\n", __func__);

Re: Adding a .platform_init callback to sdhci_arasan_ops

Hi, On Mon, Dec 5, 2016 at 4:28 AM, Sebastian Frias wrote: > Hi Doug, > > On 28/11/16 18:46, Doug Anderson wrote: >> Hi, >> >> On Mon, Nov 28, 2016 at 6:39 AM, Sebastian Frias wrote: I will try to send another patch with what a different approach >>> >>> Here's a different approach (I

Re: Adding a .platform_init callback to sdhci_arasan_ops

Hi Doug, On 28/11/16 19:02, Doug Anderson wrote: > Hi, > > On Mon, Nov 28, 2016 at 5:28 AM, Sebastian Frias wrote: >> +static void sdhci_tango4_platform_init(struct sdhci_host *host) >> +{ >> + printk("%s\n", __func__); >> + >> + /* >> + pad_mode[2:0]=0must be 0 >> +

Re: Adding a .platform_init callback to sdhci_arasan_ops

Hi Doug, On 28/11/16 18:46, Doug Anderson wrote: > Hi, > > On Mon, Nov 28, 2016 at 6:39 AM, Sebastian Frias wrote: >>> I will try to send another patch with what a different approach >>> >> >> Here's a different approach (I just tested that it built, because I don't >> have the >> rk3399 platfo

Re: Adding a .platform_init callback to sdhci_arasan_ops

Hi, On Mon, Nov 28, 2016 at 11:32 AM, Mason wrote: > On 28/11/2016 18:46, Doug Anderson wrote: > >> As argued in my original patch the field "corecfg_baseclkfreq" is >> documented in the generic Arasan document >> >> and th

Re: Adding a .platform_init callback to sdhci_arasan_ops

On 28/11/2016 18:46, Doug Anderson wrote: > As argued in my original patch the field "corecfg_baseclkfreq" is > documented in the generic Arasan document > > and thus is unlikely to be Rockchip specific. I downloaded the da

Re: Adding a .platform_init callback to sdhci_arasan_ops

Hi, On Mon, Nov 28, 2016 at 5:28 AM, Sebastian Frias wrote: > +static void sdhci_tango4_platform_init(struct sdhci_host *host) > +{ > + printk("%s\n", __func__); > + > + /* > + pad_mode[2:0]=0must be 0 > + sel_sdio[3]=1 must be 1 for SDIO > + inv_sdwp_

Re: Adding a .platform_init callback to sdhci_arasan_ops

Hi, On Mon, Nov 28, 2016 at 6:39 AM, Sebastian Frias wrote: >> I will try to send another patch with what a different approach >> > > Here's a different approach (I just tested that it built, because I don't > have the > rk3399 platform): > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c > b/

Re: Adding a .platform_init callback to sdhci_arasan_ops

On 28/11/16 14:28, Sebastian Frias wrote: > On 28/11/16 12:44, Adrian Hunter wrote: >> On 28/11/16 13:20, Sebastian Frias wrote: >>> Hi Adrian, >>> >>> On 28/11/16 11:30, Adrian Hunter wrote: On 28/11/16 09:32, Michal Simek wrote: > +Sai for Xilinx perspective. > > On 25.11.2016 16

Re: Adding a .platform_init callback to sdhci_arasan_ops

On 28/11/16 12:44, Adrian Hunter wrote: > On 28/11/16 13:20, Sebastian Frias wrote: >> Hi Adrian, >> >> On 28/11/16 11:30, Adrian Hunter wrote: >>> On 28/11/16 09:32, Michal Simek wrote: +Sai for Xilinx perspective. On 25.11.2016 16:24, Sebastian Frias wrote: > Hi, > > Wh

Re: Adding a .platform_init callback to sdhci_arasan_ops

On 28/11/16 13:20, Sebastian Frias wrote: > Hi Adrian, > > On 28/11/16 11:30, Adrian Hunter wrote: >> On 28/11/16 09:32, Michal Simek wrote: >>> +Sai for Xilinx perspective. >>> >>> On 25.11.2016 16:24, Sebastian Frias wrote: Hi, When using the Arasan SDHCI HW IP, there is a set of

Re: Adding a .platform_init callback to sdhci_arasan_ops

Hi Adrian, On 28/11/16 11:30, Adrian Hunter wrote: > On 28/11/16 09:32, Michal Simek wrote: >> +Sai for Xilinx perspective. >> >> On 25.11.2016 16:24, Sebastian Frias wrote: >>> Hi, >>> >>> When using the Arasan SDHCI HW IP, there is a set of parameters called >>> "Hardware initialized registers"

Re: Adding a .platform_init callback to sdhci_arasan_ops

On 28/11/16 09:32, Michal Simek wrote: > +Sai for Xilinx perspective. > > On 25.11.2016 16:24, Sebastian Frias wrote: >> Hi, >> >> When using the Arasan SDHCI HW IP, there is a set of parameters called >> "Hardware initialized registers" >> >> (Table 7, Section "Pin Signals", page 56 of Arasan "SD

Re: Adding a .platform_init callback to sdhci_arasan_ops

+Sai for Xilinx perspective. On 25.11.2016 16:24, Sebastian Frias wrote: > Hi, > > When using the Arasan SDHCI HW IP, there is a set of parameters called > "Hardware initialized registers" > > (Table 7, Section "Pin Signals", page 56 of Arasan "SD3.0/SDIO3.0/eMMC4.4 > AHB Host Controller", revis